From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: groug@kaod.org, mark.cave-ayland@ilande.co.uk,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org, lvivier@redhat.com,
David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 05/12] spapr: set vsmt to MAX(8, smp_threads)
Date: Mon, 12 Feb 2018 14:40:47 +1100 [thread overview]
Message-ID: <20180212034054.23441-6-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20180212034054.23441-1-david@gibson.dropbear.id.au>
From: Laurent Vivier <lvivier@redhat.com>
We ignore silently the value of smp_threads when we set
the default VSMT value, and if smp_threads is greater than VSMT
kernel is going into trouble later.
Fixes: 8904e5a750
("spapr: Adjust default VSMT value for better migration compatibility")
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/ppc/spapr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 96515036e6..9f29434819 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -2310,7 +2310,7 @@ static void spapr_set_vsmt_mode(sPAPRMachineState *spapr, Error **errp)
* the value that we'd get with KVM on POWER8, the
* overwhelmingly common case in production systems.
*/
- spapr->vsmt = 8;
+ spapr->vsmt = MAX(8, smp_threads);
}
/* KVM: If necessary, set the SMT mode: */
--
2.14.3
next prev parent reply other threads:[~2018-02-12 3:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 3:40 [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180212 David Gibson
2018-02-12 3:40 ` [Qemu-devel] [PULL 01/12] spapr: add missing break in h_get_cpu_characteristics() David Gibson
2018-02-12 3:40 ` [Qemu-devel] [PULL 02/12] hw/ppc: rename functions in comments David Gibson
2018-02-12 3:40 ` [Qemu-devel] [PULL 03/12] cuda: do not use old_mmio accesses David Gibson
2018-02-12 3:40 ` [Qemu-devel] [PULL 04/12] cuda: don't allow writes to port output pins David Gibson
2018-02-12 3:40 ` David Gibson [this message]
2018-02-12 3:40 ` [Qemu-devel] [PULL 06/12] cuda: introduce CUDAState parameter to get_counter() David Gibson
2018-02-12 3:40 ` [Qemu-devel] [PULL 07/12] cuda: rename frequency property to tb_frequency David Gibson
2018-02-12 3:40 ` [Qemu-devel] [PULL 08/12] cuda: minor cosmetic tidy-ups to get_next_irq_time() David Gibson
2018-02-12 3:40 ` [Qemu-devel] [PULL 09/12] cuda: don't call cuda_update() when writing to ACR register David Gibson
2018-02-12 3:40 ` [Qemu-devel] [PULL 10/12] cuda: set timer 1 frequency property to CUDA_TIMER_FREQ David Gibson
2018-02-12 3:40 ` [Qemu-devel] [PULL 11/12] cuda: factor out timebase-derived counter value and load time David Gibson
2018-02-12 3:40 ` [Qemu-devel] [PULL 12/12] misc: introduce new mos6522 VIA device and enable it for ppc builds David Gibson
2018-02-12 17:40 ` [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180212 Peter Maydell
2018-02-12 18:46 ` Laurent Vivier
2018-02-12 22:11 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212034054.23441-6-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).