Re: [Qemu-devel] [PATCH 2/3] block: test blk_aio_flush() with blk->root == NULL

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]

On Fri, Feb 09, 2018 at 09:23:53AM -0600, Eric Blake wrote:
> On 02/08/2018 11:18 AM, Stefan Hajnoczi wrote:
> > From: Kevin Wolf <kwolf@redhat.com>
> > 
> > This patch adds test cases for the scenario where blk_aio_flush() is
> > called on a BlockBackend with no root.  Calling drain afterwards should
> > complete the requests with -ENOMEDIUM.
> > 
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> >   tests/Makefile.include     |  2 ++
> >   tests/test-block-backend.c | 82 ++++++++++++++++++++++++++++++++++++++++++++++
> >   2 files changed, 84 insertions(+)
> >   create mode 100644 tests/test-block-backend.c
> > 
> 
> > +++ b/tests/test-block-backend.c
> > @@ -0,0 +1,82 @@
> > +/*
> > + * BlockBackend tests
> > + *
> > + * Copyright (c) 2017 Kevin Wolf <kwolf@redhat.com>
> 
> Want to include 2018?  Using a redhat.com address but a personal copyright?
> (Then again, Red Hat has some pretty cool policies on what it permits for
> code written on an employee's own time).
> 
> As long as Kevin is happy with the final copyright line that goes into the
> commit:
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

This is how I got the test case from Kevin, I didn't change the
copyright line.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]