From: Peter Xu <peterx@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] migration: Fix early failure crash
Date: Tue, 13 Feb 2018 11:56:47 +0800 [thread overview]
Message-ID: <20180213035647.GE4472@xz-mi> (raw)
In-Reply-To: <20180212160340.15333-1-dgilbert@redhat.com>
On Mon, Feb 12, 2018 at 04:03:38PM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> This fixes a crash for the case where a migration exits with an error
> very early, this is probably due to my recent error handling change.
>
> I also add a test to make sure this doesn't fail again, the test does
> output one line of junk, suggestions for how to clean it up are welcome:
>
> [dgilbert@dgilbert-t530 try]$ tests/migration-test
> /x86_64/migration/deprecated: OK
> /x86_64/migration/bad_dest: qemu-system-x86_64: Failed to connect socket: Connection refused
> OK
> /x86_64/migration/postcopy/unix: OK
So we have more than one way to log things (error_report routes things
directly to stderr while we also have the qemu log stuff).
A stupid but fast way I can think of is just don't dump this in
migrate_fd_cleanup, since after all it's only for HMP and people
should also see that when query migration status. But it'll be a bit
inconvenient for HMP users encountering failures.
Or maybe we can hack around fd 2 specifically in that test? It's at
least ugly though...
Anyway, the patches look good to me.
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
prev parent reply other threads:[~2018-02-13 3:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 16:03 [Qemu-devel] [PATCH 0/2] migration: Fix early failure crash Dr. David Alan Gilbert (git)
2018-02-12 16:03 ` [Qemu-devel] [PATCH 1/2] migration: Fix early failure cleanup Dr. David Alan Gilbert (git)
2018-02-12 16:03 ` [Qemu-devel] [PATCH 2/2] tests/migration: Add test for migration to bad destination Dr. David Alan Gilbert (git)
2018-02-20 11:56 ` Thomas Huth
2018-02-20 13:26 ` Juan Quintela
2018-02-13 3:56 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213035647.GE4472@xz-mi \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).