From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ela3q-0005Mp-9Q for qemu-devel@nongnu.org; Tue, 13 Feb 2018 07:51:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ela3l-0006k3-Cq for qemu-devel@nongnu.org; Tue, 13 Feb 2018 07:51:50 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:41126 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ela3l-0006ii-6o for qemu-devel@nongnu.org; Tue, 13 Feb 2018 07:51:45 -0500 From: "Dr. David Alan Gilbert (git)" Date: Tue, 13 Feb 2018 12:51:43 +0000 Message-Id: <20180213125143.23488-1-dgilbert@redhat.com> Subject: [Qemu-devel] [PATCH] monitor.c: Fix infinite loop in monitor's auto-complete List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, t.pagef.lt@gmail.com Cc: kwolf@redhat.com From: "Dr. David Alan Gilbert" Reported-by: Dimitris Karagkasidis Fixes: 48fe86f6400574165979e0db6f5937ad487b6888 Signed-off-by: Dr. David Alan Gilbert --- monitor.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 0c0faec0a4..bec484440f 100644 --- a/monitor.c +++ b/monitor.c @@ -3696,7 +3696,7 @@ static void monitor_find_completion_by_table(Monitor *mon, { const char *cmdname; int i; - const char *ptype, *str, *name; + const char *ptype, *old_ptype, *str, *name; const mon_cmd_t *cmd; BlockBackend *blk = NULL; @@ -3741,7 +3741,9 @@ static void monitor_find_completion_by_table(Monitor *mon, } } str = args[nb_args - 1]; - while (*ptype == '-' && ptype[1] != '\0') { + old_ptype = NULL; + while (*ptype == '-' && old_ptype != ptype) { + old_ptype = ptype; ptype = next_arg_type(ptype); } switch(*ptype) { -- 2.14.3