From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elciy-0003Yb-LV for qemu-devel@nongnu.org; Tue, 13 Feb 2018 10:42:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elciu-0004l1-Da for qemu-devel@nongnu.org; Tue, 13 Feb 2018 10:42:28 -0500 Received: from mx2.suse.de ([195.135.220.15]:49162) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1elciu-0004ke-6f for qemu-devel@nongnu.org; Tue, 13 Feb 2018 10:42:24 -0500 Date: Tue, 13 Feb 2018 16:41:51 +0100 From: Borislav Petkov Message-ID: <20180213154151.GC12578@pd.tnic> References: <20180212153715.87555-1-brijesh.singh@amd.com> <20180212153715.87555-6-brijesh.singh@amd.com> <20180212183803.GR13981@localhost.localdomain> <4a1f22d9-da2e-618b-1423-629817389948@amd.com> <20180212211948.GK14422@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v8 05/28] target/i386: add memory encryption feature cpuid support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brijesh Singh Cc: Brijesh Singh , Eduardo Habkost , "Edgar E. Iglesias" , Peter Maydell , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcel Apfelbaum , Markus Armbruster , Peter Crosthwaite , Richard Henderson , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Christian Borntraeger , Alexander Graf , Stefan Hajnoczi , Cornelia Huck , Paolo Bonzini , Thomas Lendacky , Alistair Francis , Bruce Rogers , Richard Henderson On Tue, Feb 13, 2018 at 09:39:01AM -0600, Brijesh Singh wrote: > Yes, I think we should be able to avoid creating new CPU model to > handle this case. I am leaning towards dropping this patch and > implement logic to populate the CPUID 0x8000_001F only when SEV is > enabled. This should not require any changes in existing CPU model > feature flag and live migration of existing guest should work fine. That sounds even nicer. Thx. --=20 Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton= , HRB 21284 (AG N=C3=BCrnberg) --=20