From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 01/55] iotests: Fix CID for VMDK afl image
Date: Tue, 13 Feb 2018 18:04:35 +0100 [thread overview]
Message-ID: <20180213170529.10858-2-kwolf@redhat.com> (raw)
In-Reply-To: <20180213170529.10858-1-kwolf@redhat.com>
From: Fam Zheng <famz@redhat.com>
This reverts commit 76bf133c4 which updated the reference output, and
fixed the reference image, because the code path we want to exercise is
actually the invalid image size.
The descriptor block in the image, which includes the CID to verify, has been
invalid since the reference image was added. Since commit 9877860e7bd we report
this error earlier than the "file too large", so 059.out mismatches.
The binary change is generated along the operations of:
$ bunzip2 afl9.vmdk.bz2
$ qemu-img create -f vmdk fix.vmdk 1G
$ dd if=afl9.vmdk of=fix.vmdk bs=512 count=1 conv=notrunc
$ mv fix.vmdk afl9.vmdk
$ bzip2 afl9.vmdk
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
tests/qemu-iotests/059.out | 2 +-
tests/qemu-iotests/sample_images/afl9.vmdk.bz2 | Bin 178 -> 618 bytes
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/059.out b/tests/qemu-iotests/059.out
index 1ac5d56233..f6dce7947c 100644
--- a/tests/qemu-iotests/059.out
+++ b/tests/qemu-iotests/059.out
@@ -2358,5 +2358,5 @@ Offset Length Mapped to File
0x140000000 0x10000 0x50000 TEST_DIR/t-s003.vmdk
=== Testing afl image with a very large capacity ===
-qemu-img: Could not open 'TEST_DIR/afl9.IMGFMT': Could not open 'TEST_DIR/afl9.IMGFMT': Invalid argument
+qemu-img: Can't get image size 'TEST_DIR/afl9.IMGFMT': File too large
*** done
diff --git a/tests/qemu-iotests/sample_images/afl9.vmdk.bz2 b/tests/qemu-iotests/sample_images/afl9.vmdk.bz2
index 03615d36a12425cf4240bab86f4cfe648db14572..9fcd0af45a815431acf4689e0845ecf2d333cd58 100644
GIT binary patch
literal 618
zcmV-w0+szjT4*^jL0KkKSvgW7ssIN3|NsBH-Q9UpfAhclU70`s-*NE~5QvC~h=_=Y
zh>D2n*q*=vygR634445h35k;?00h9835kMW00004$iPepVE{Bqk)uhJ^wfGLr=)3s
zhM5CR88jLh7)B;cA*K)*6GmuECPU3o4NWG5O#pg>Ak#xY8Z^<M8Z>CrMt}oD38Ns$
z02n}M0LdjZ&}cLPqd+nPKmn$j0iXe(02%-d27nnJriN-uE+X&cz@Bj4BBfd|yV!NB
zwqkL}nW3AI5x^jp=t%^F1pxqp)v#n#)j$zcm1xqv(!$2d*5%vF{5RPWnOV8-^tE<(
zU~%&}Y0uNu*9Wt=yS^8PkC&gPueZO%IG;aD{l#sG`<Af;l1Pnwpi9I75FkQ`LLhd8
z6(9f*2s+N5=%bwp80ddrD6>m4Ho*fsHXdM<jtl*zKvRiTx7Ugy1|Nl<Ns!z;1dvhy
z=`SDHh~{u|1ZodC(_lzezQ)I*Kv2z|PZ@!SJjlVzwGdx2iu#W}dI{t+T&dDWT^LPy
zg3NouEM=V~7GvZQS1CXy676F6mJXWGgW!KTr+E$OspGYCjWmuwa^<Bc>_(-i7fPIW
zA+~n9iy_f)g8B2RILhd%F)dZ5f?7pFLw)@;Ncl<JE}gvMrfh{elT#3gLjY6r8xY4O
z)UO#pv=WYptukn<DuoMH2ip%k?V^k!rjQirK^RC<Brw>3Bz9<|!xm0F{45K+gg8#n
z4FNAJ!<X|3Vq+lyV4=xZ;>AN0<K=%c4A2ruB!4rGvWm!KFrvd4PyfZ-kxmpO4pfM$
EfLnqQYXATM
literal 178
zcmV;j08RfwT4*^jL0KkKS>A08g#Z9x|HJ$H)ZJi0004xF0SE*D03g5s00IDLSQelF
ziVX^$pfWNUJrmRhn2k52pQ;Rs0EQC;(S%|!m`2~BZ@b++;etskRJUVl!Kt)wu7?VN
zl;%JdqX2?TgsNVJP?87M*MvL1qQnBkCES&?0@MeaN-bL4;bDzxmMm|da4fuh!=#fu
g@i9R@5z!av{9tA<GGr!3hi~HUNT&)C8_l7xpl%OKQ2+n{
--
2.13.6
next prev parent reply other threads:[~2018-02-13 17:05 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 17:04 [Qemu-devel] [PULL 00/55] Block layer patches Kevin Wolf
2018-02-13 17:04 ` Kevin Wolf [this message]
2018-02-13 17:04 ` [Qemu-devel] [PULL 02/55] qemu-img.texi: Clean up parameter list Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 03/55] qemu-img: Document --force-share / -U Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 04/55] docs: Document share-rw property more thoroughly Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 05/55] qcow2: Use g_try_realloc() in qcow2_expand_zero_clusters() Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 06/55] block: early check for blockers on drive-mirror Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 07/55] iotests: Use virtio-blk in 155 Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 08/55] qemu-io: fix EOF Ctrl-D handling in qemu-io readline code Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 09/55] gluster: Move glfs_close() to create's clean-up Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 10/55] gluster: Pull truncation from qemu_gluster_create Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 11/55] gluster: Query current size in do_truncate() Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 12/55] gluster: Add preallocated truncation Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 13/55] sheepdog: Make sd_prealloc() take a BDS Kevin Wolf
2018-05-08 15:33 ` Peter Maydell
2018-02-13 17:04 ` [Qemu-devel] [PULL 14/55] sheepdog: Pass old and new size to sd_prealloc() Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 15/55] sheepdog: Allow fully preallocated truncation Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 16/55] block: maintain persistent disabled bitmaps Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 17/55] qcow2: Fix documentation of get_cluster_table() Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 18/55] qcow2: Add table size field to Qcow2Cache Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 19/55] qcow2: Remove BDS parameter from qcow2_cache_get_table_addr() Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 20/55] qcow2: Remove BDS parameter from qcow2_cache_get_table_idx() Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 21/55] qcow2: Remove BDS parameter from qcow2_cache_table_release() Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 22/55] qcow2: Remove BDS parameter from qcow2_cache_entry_mark_dirty() Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 23/55] qcow2: Remove BDS parameter from qcow2_cache_put() Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 24/55] qcow2: Remove BDS parameter from qcow2_cache_destroy() Kevin Wolf
2018-02-13 17:04 ` [Qemu-devel] [PULL 25/55] qcow2: Remove BDS parameter from qcow2_cache_clean_unused() Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 26/55] qcow2: Remove BDS parameter from qcow2_cache_discard() Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 27/55] qcow2: Remove BDS parameter from qcow2_cache_is_table_offset() Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 28/55] qcow2: Add offset_to_l1_index() Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 29/55] qcow2: Add l2_slice_size field to BDRVQcow2State Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 30/55] qcow2: Add offset_to_l2_slice_index() Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 31/55] qcow2: Update l2_load() to support L2 slices Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 32/55] qcow2: Prepare l2_allocate() for adding L2 slice support Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 33/55] qcow2: Update l2_allocate() to support L2 slices Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 34/55] qcow2: Refactor get_cluster_table() Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 35/55] qcow2: Update get_cluster_table() to support L2 slices Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 36/55] qcow2: Update qcow2_get_cluster_offset() " Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 37/55] qcow2: Update qcow2_alloc_cluster_link_l2() " Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 38/55] qcow2: Update handle_copied() " Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 39/55] qcow2: Update handle_alloc() " Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 40/55] qcow2: Update discard_single_l2() " Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 41/55] qcow2: Update zero_single_l2() " Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 42/55] qcow2: Prepare qcow2_update_snapshot_refcount() for adding L2 slice support Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 43/55] qcow2: Update qcow2_update_snapshot_refcount() to support L2 slices Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 44/55] qcow2: Read refcount before L2 table in expand_zero_clusters_in_l1() Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 45/55] qcow2: Prepare expand_zero_clusters_in_l1() for adding L2 slice support Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 46/55] qcow2: Update expand_zero_clusters_in_l1() to support L2 slices Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 47/55] qcow2: Update qcow2_truncate() " Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 48/55] qcow2: Rename l2_table in qcow2_alloc_compressed_cluster_offset() Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 49/55] qcow2: Rename l2_table in count_contiguous_clusters() Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 50/55] qcow2: Rename l2_table in count_contiguous_clusters_unallocated() Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 51/55] qcow2: Rename l2_table in count_cow_clusters() Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 52/55] qcow2: Allow configuring the L2 slice size Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 53/55] iotests: Test valid values of l2-cache-entry-size Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 54/55] iotests: Test downgrading an image using a small L2 slice size Kevin Wolf
2018-02-13 17:05 ` [Qemu-devel] [PULL 55/55] iotests: Add l2-cache-entry-size to iotest 137 Kevin Wolf
2018-02-15 10:13 ` [Qemu-devel] [PULL 00/55] Block layer patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213170529.10858-2-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).