From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, berto@igalia.com, mreitz@redhat.com,
Kevin Wolf <kwolf@redhat.com>
Subject: [Qemu-devel] [PATCH 1/2] qcow2: Prefer 'entries' over 'size' for non-byte values in spec
Date: Tue, 13 Feb 2018 17:33:23 -0600 [thread overview]
Message-ID: <20180213233324.5096-2-eblake@redhat.com> (raw)
In-Reply-To: <20180213233324.5096-1-eblake@redhat.com>
We want to limit the use of the term 'size' for only values that
count by bytes. Renaming fields in the spec does not invalidate
any existing implementation, but may make future implementations
easier to write.
A reasonable followup would be to rename internal qemu code that
operates on qcow2 images to also use the distinction between
size and entries in variable names.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
docs/interop/qcow2.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt
index d7fdb1fee31..597d3f261d5 100644
--- a/docs/interop/qcow2.txt
+++ b/docs/interop/qcow2.txt
@@ -47,7 +47,7 @@ The first cluster of a qcow2 image contains the file header:
1 for AES encryption
2 for LUKS encryption
- 36 - 39: l1_size
+ 36 - 39: l1_entries
Number of entries in the active L1 table
40 - 47: l1_table_offset
@@ -538,7 +538,7 @@ Structure of a bitmap directory entry:
(described below) for the bitmap starts. Must be aligned to
a cluster boundary.
- 8 - 11: bitmap_table_size
+ 8 - 11: bitmap_table_entries
Number of entries in the bitmap table of the bitmap.
12 - 15: flags
--
2.14.3
next prev parent reply other threads:[~2018-02-13 23:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 23:33 [Qemu-devel] [RFC PATCH 0/2] s/size/entries/ when dealing with non-byte units Eric Blake
2018-02-13 23:33 ` Eric Blake [this message]
2018-02-13 23:33 ` [Qemu-devel] [PATCH 2/2] qcow2: Prefer 'entries' over 'size' during cache creation Eric Blake
2018-02-14 20:54 ` [Qemu-devel] [RFC PATCH 0/2] s/size/entries/ when dealing with non-byte units Max Reitz
2018-02-15 8:47 ` Alberto Garcia
2018-02-15 10:09 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213233324.5096-2-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).