From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elikJ-00058C-Vf for qemu-devel@nongnu.org; Tue, 13 Feb 2018 17:08:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elikF-0003qm-0e for qemu-devel@nongnu.org; Tue, 13 Feb 2018 17:08:15 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35692 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1elikE-0003qY-RC for qemu-devel@nongnu.org; Tue, 13 Feb 2018 17:08:10 -0500 Date: Wed, 14 Feb 2018 00:07:53 +0200 From: "Michael S. Tsirkin" Message-ID: <20180214000454-mutt-send-email-mst@kernel.org> References: <938dc32019864c9c19259bdddd64a53b6b99efef.1512476043.git.tgolembi@redhat.com> <20180205130824.79f570bc@fiorina> <1e6717d5-a1bc-3409-b01f-24ea761659fb@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1e6717d5-a1bc-3409-b01f-24ea761659fb@oracle.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jonathan Helman Cc: =?utf-8?B?VG9tw6HFoSBHb2xlbWJpb3Zza8O9?= , virtio-dev@lists.oasis-open.org, qemu-devel@nongnu.org, Wei Wang On Tue, Feb 13, 2018 at 12:29:39PM -0800, Jonathan Helman wrote: >=20 >=20 > On 02/05/2018 04:08 AM, Tom=C3=A1=C5=A1 Golembiovsk=C3=BD wrote: > > ping > >=20 > > On Tue, 5 Dec 2017 13:14:46 +0100 > > Tom=C3=A1=C5=A1 Golembiovsk=C3=BD wrote: > >=20 >=20 > It would be good to include the corresponding upstream kernel change in= the > commit message. This would be similar to a previous change: > https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg05555.html good idea, but this has been merged by now. > > > Signed-off-by: Tom=C3=A1=C5=A1 Golembiovsk=C3=BD > > > --- > > > hw/virtio/virtio-balloon.c | 1 + > > > include/standard-headers/linux/virtio_balloon.h | 3 ++- > > > 2 files changed, 3 insertions(+), 1 deletion(-) > > >=20 > > > diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.= c > > > index 37cde38982..8141326a51 100644 > > > --- a/hw/virtio/virtio-balloon.c > > > +++ b/hw/virtio/virtio-balloon.c > > > @@ -50,6 +50,7 @@ static const char *balloon_stat_names[] =3D { > > > [VIRTIO_BALLOON_S_MEMFREE] =3D "stat-free-memory", > > > [VIRTIO_BALLOON_S_MEMTOT] =3D "stat-total-memory", > > > [VIRTIO_BALLOON_S_AVAIL] =3D "stat-available-memory", > > > + [VIRTIO_BALLOON_S_CACHES] =3D "stat-disk-caches", > > > [VIRTIO_BALLOON_S_NR] =3D NULL > > > }; > > > diff --git a/include/standard-headers/linux/virtio_balloon.h b/incl= ude/standard-headers/linux/virtio_balloon.h > > > index 9d06ccd066..7b0a41b8fc 100644 > > > --- a/include/standard-headers/linux/virtio_balloon.h > > > +++ b/include/standard-headers/linux/virtio_balloon.h > > > @@ -52,7 +52,8 @@ struct virtio_balloon_config { > > > #define VIRTIO_BALLOON_S_MEMFREE 4 /* Total amount of free mem= ory */ > > > #define VIRTIO_BALLOON_S_MEMTOT 5 /* Total amount of memory *= / > > > #define VIRTIO_BALLOON_S_AVAIL 6 /* Available memory as in /= proc */ > > > -#define VIRTIO_BALLOON_S_NR 7 > > > +#define VIRTIO_BALLOON_S_CACHES 7 /* Disk caches */ >=20 > I've been wondering, VIRTIO_BALLOON_S_AVAIL is not in the virtio spec (= see > Section 5.5.6.3). It seems like this header file needs to be in sync wi= th > the virtio spec in order to make this change. >=20 > I have a similar change to add a new statistic and was wondering this. Absolutely. Tom=C3=A1=C5=A1? > > > +#define VIRTIO_BALLOON_S_NR 8 > > > /* > > > * Memory statistics structure. > > > --=20 > > > 2.15.1 > > >=20 > >=20 > >=20 >=20 > You need to add your new stat to the list of stats in > docs/virtio-balloon-stats.txt. >=20 > Jon Can't hurt, I agree. --=20 MST