From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elu36-00019R-3h for qemu-devel@nongnu.org; Wed, 14 Feb 2018 05:12:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elu31-0003Gz-D5 for qemu-devel@nongnu.org; Wed, 14 Feb 2018 05:12:24 -0500 Date: Wed, 14 Feb 2018 11:11:58 +0100 From: Cornelia Huck Message-ID: <20180214111158.68881e63.cohuck@redhat.com> In-Reply-To: <1518542328-25741-3-git-send-email-mihajlov@linux.vnet.ibm.com> References: <1518542328-25741-1-git-send-email-mihajlov@linux.vnet.ibm.com> <1518542328-25741-3-git-send-email-mihajlov@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2 2/3] qmp: add query-cpus-fast List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Viktor Mihajlovski Cc: qemu-devel@nongnu.org, agraf@suse.de, ehabkost@redhat.com, armbru@redhat.com, david@redhat.com, dgilbert@redhat.com, borntraeger@de.ibm.com, qemu-s390x@nongnu.org, pbonzini@redhat.com, rth@twiddle.net, eblake@redhat.com On Tue, 13 Feb 2018 18:18:47 +0100 Viktor Mihajlovski wrote: > From: Luiz Capitulino > > The query-cpus command has an extremely serious side effect: > it always interrupts all running vCPUs so that they can run > ioctl calls. This can cause a huge performance degradation for > some workloads. And most of the information retrieved by the > ioctl calls are not even used by query-cpus. > > This commit introduces a replacement for query-cpus called > query-cpus-fast, which has the following features: > > o Never interrupt vCPUs threads. query-cpus-fast only returns > vCPU information maintained by QEMU itself, which should be > sufficient for most management software needs > > o Make "halted" field optional: we only return it if the > halted state is maintained by QEMU. But this also gives > the option of dropping the field in the future (see below) > > o Drop irrelevant fields such as "current", "pc", "arch" > and "halted" I'd suggest updating this description, as "halted" is now gone completely... what about: o Drop the "halted" field, even if the halted state is maintained by QEMU. It had unclear semantics anyway. o Drop irrelevant fields such as "current", "pc", or "arch" > > o Rename some fields for better clarification & proper naming > standard > > Signed-off-by: Luiz Capitulino > Signed-off-by: Viktor Mihajlovski > --- > cpus.c | 38 ++++++++++++++++++++++++++++ > hmp-commands-info.hx | 14 +++++++++++ > hmp.c | 14 +++++++++++ > hmp.h | 1 + > qapi-schema.json | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 137 insertions(+) Otherwise, looks good to me. Reviewed-by: Cornelia Huck