From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, quintela@redhat.com, peterx@redhat.com,
groug@kaod.org, ross.lagerwall@citrix.com
Subject: [Qemu-devel] [PULL 04/10] migration: Fix early failure cleanup
Date: Wed, 14 Feb 2018 15:39:32 +0000 [thread overview]
Message-ID: <20180214153938.5410-5-dgilbert@redhat.com> (raw)
In-Reply-To: <20180214153938.5410-1-dgilbert@redhat.com>
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Avoid crash in cleanup after a very early migration failure
(possibly due to my 688a3dcba980bf01344a 'Route errors down ...')
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20180212160340.15333-2-dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
---
migration/ram.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 8333d8e35e..7095c1040e 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1602,11 +1602,13 @@ static void xbzrle_load_cleanup(void)
static void ram_state_cleanup(RAMState **rsp)
{
- migration_page_queue_free(*rsp);
- qemu_mutex_destroy(&(*rsp)->bitmap_mutex);
- qemu_mutex_destroy(&(*rsp)->src_page_req_mutex);
- g_free(*rsp);
- *rsp = NULL;
+ if (*rsp) {
+ migration_page_queue_free(*rsp);
+ qemu_mutex_destroy(&(*rsp)->bitmap_mutex);
+ qemu_mutex_destroy(&(*rsp)->src_page_req_mutex);
+ g_free(*rsp);
+ *rsp = NULL;
+ }
}
static void xbzrle_cleanup(void)
--
2.14.3
next prev parent reply other threads:[~2018-02-14 15:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 15:39 [Qemu-devel] [PULL 00/10] migration queue Dr. David Alan Gilbert (git)
2018-02-14 15:39 ` [Qemu-devel] [PULL 01/10] migration/xen: Check return value of qemu_fclose Dr. David Alan Gilbert (git)
2018-02-14 15:39 ` [Qemu-devel] [PULL 02/10] migration: improve documentation of postcopy-ram Dr. David Alan Gilbert (git)
2018-02-14 15:39 ` [Qemu-devel] [PULL 03/10] tests/migration: Add source to PC boot block Dr. David Alan Gilbert (git)
2018-02-14 15:39 ` Dr. David Alan Gilbert (git) [this message]
2018-02-14 15:39 ` [Qemu-devel] [PULL 05/10] tests/migration: Add test for migration to bad destination Dr. David Alan Gilbert (git)
2018-02-14 15:39 ` [Qemu-devel] [PULL 06/10] migration: better error handling with QEMUFile Dr. David Alan Gilbert (git)
2018-02-14 15:39 ` [Qemu-devel] [PULL 07/10] migration: reuse mis->userfault_quit_fd Dr. David Alan Gilbert (git)
2018-02-14 15:39 ` [Qemu-devel] [PULL 08/10] migration: provide postcopy_fault_thread_notify() Dr. David Alan Gilbert (git)
2018-02-14 15:39 ` [Qemu-devel] [PULL 09/10] migration: allow send_rq to fail Dr. David Alan Gilbert (git)
2018-02-14 15:39 ` [Qemu-devel] [PULL 10/10] migration: pass MigrationState to migrate_init() Dr. David Alan Gilbert (git)
2018-02-15 15:45 ` [Qemu-devel] [PULL 00/10] migration queue Peter Maydell
2018-02-15 20:19 ` Dr. David Alan Gilbert
2018-02-16 6:14 ` Thomas Huth
2018-02-16 14:25 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214153938.5410-5-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=groug@kaod.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=ross.lagerwall@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).