From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
"Richard W . M . Jones" <rjones@redhat.com>,
Jeff Cody <jcody@redhat.com>
Subject: [Qemu-devel] [PATCH 3/3] block/ssh: Add basic .bdrv_truncate()
Date: Wed, 14 Feb 2018 21:49:15 +0100 [thread overview]
Message-ID: <20180214204915.7980-4-mreitz@redhat.com> (raw)
In-Reply-To: <20180214204915.7980-1-mreitz@redhat.com>
libssh2 does not seem to offer real truncation support, so we can only
grow files -- but that is better than nothing.
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
block/ssh.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/block/ssh.c b/block/ssh.c
index ff8576f21e..c235eec255 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -1219,6 +1219,29 @@ static int64_t ssh_getlength(BlockDriverState *bs)
return length;
}
+static int ssh_truncate(BlockDriverState *bs, int64_t offset,
+ PreallocMode prealloc, Error **errp)
+{
+ BDRVSSHState *s = bs->opaque;
+
+ if (prealloc != PREALLOC_MODE_OFF) {
+ error_setg(errp, "Unsupported preallocation mode '%s'",
+ PreallocMode_str(prealloc));
+ return -ENOTSUP;
+ }
+
+ if (offset < s->attrs.filesize) {
+ error_setg(errp, "ssh driver does not support shrinking files");
+ return -ENOTSUP;
+ }
+
+ if (offset == s->attrs.filesize) {
+ return 0;
+ }
+
+ return ssh_grow_file(s, offset, errp);
+}
+
static BlockDriver bdrv_ssh = {
.format_name = "ssh",
.protocol_name = "ssh",
@@ -1231,6 +1254,7 @@ static BlockDriver bdrv_ssh = {
.bdrv_co_readv = ssh_co_readv,
.bdrv_co_writev = ssh_co_writev,
.bdrv_getlength = ssh_getlength,
+ .bdrv_truncate = ssh_truncate,
.bdrv_co_flush_to_disk = ssh_co_flush,
.create_opts = &ssh_create_opts,
};
--
2.14.3
next prev parent reply other threads:[~2018-02-14 20:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 20:49 [Qemu-devel] [PATCH 0/3] block/ssh: Add basic .bdrv_truncate() Max Reitz
2018-02-14 20:49 ` [Qemu-devel] [PATCH 1/3] block/ssh: Pull ssh_grow_file() from ssh_create() Max Reitz
2018-02-14 21:08 ` Eric Blake
2018-02-14 20:49 ` [Qemu-devel] [PATCH 2/3] block/ssh: Make ssh_grow_file() blocking Max Reitz
2018-02-14 21:11 ` Eric Blake
2018-02-14 21:28 ` Max Reitz
2018-02-14 20:49 ` Max Reitz [this message]
2018-02-14 21:12 ` [Qemu-devel] [PATCH 3/3] block/ssh: Add basic .bdrv_truncate() Eric Blake
2018-02-15 11:12 ` Richard W.M. Jones
2018-02-23 13:51 ` [Qemu-devel] [PATCH 0/3] " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214204915.7980-4-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).