From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emGB0-0007rz-FA for qemu-devel@nongnu.org; Thu, 15 Feb 2018 04:50:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emGAv-0007Z2-MX for qemu-devel@nongnu.org; Thu, 15 Feb 2018 04:50:02 -0500 Date: Thu, 15 Feb 2018 10:49:53 +0100 From: Cornelia Huck Message-ID: <20180215104953.1fa574ba.cohuck@redhat.com> In-Reply-To: <4c8b5c14-bef0-ef8a-1237-5146c3ee37b1@redhat.com> References: <20180214173102.9363-1-david@redhat.com> <4c8b5c14-bef0-ef8a-1237-5146c3ee37b1@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v2] s390x/tcg: add various alignment check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: Richard Henderson , qemu-s390x@nongnu.org, qemu-devel@nongnu.org, Alexander Graf On Thu, 15 Feb 2018 10:47:45 +0100 David Hildenbrand wrote: > On 14.02.2018 20:04, Richard Henderson wrote: > > On 02/14/2018 09:31 AM, David Hildenbrand wrote: > >> Let's add proper alignment checks for a handful of instructions that > >> require a SPECIFICATION exception in case alignment is violated. > >> > >> Introduce new wout/in functions. Declare them as "static inline" to avoid > >> warnings about not being used for CONFIG_USER_ONLY (as we are right > >> now only using them for privileged instructions). > > > > Annoyingly, clang will still warn for this. > > > > Hm, so the only solution is to add nasty idfefs then :( Yup, very annoying indeed, but probably the only way to shut clang up...