From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 1/9] vnc: remove bogus object_unref on client socket
Date: Fri, 16 Feb 2018 12:54:02 +0100 [thread overview]
Message-ID: <20180216115410.27287-2-kraxel@redhat.com> (raw)
In-Reply-To: <20180216115410.27287-1-kraxel@redhat.com>
From: Daniel P. Berrangé <berrange@redhat.com>
vnc_listen_io() does not own the reference on the 'cioc' parameter is it
passed, so should not be unref'ing it.
Fixes: 13e1d0e71e78a925848258391a6e616b6b5ae219
Reported-by: Bandan Das <bsd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 20180215102602.10864-1-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/vnc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index c715bae1cf..b97769aa9e 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3152,7 +3152,6 @@ static void vnc_listen_io(QIONetListener *listener,
isWebsock ? "vnc-ws-server" : "vnc-server");
qio_channel_set_delay(QIO_CHANNEL(cioc), false);
vnc_connect(vd, cioc, false, isWebsock);
- object_unref(OBJECT(cioc));
}
static const DisplayChangeListenerOps dcl_ops = {
--
2.9.3
next prev parent reply other threads:[~2018-02-16 11:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 11:54 [Qemu-devel] [PULL 0/9] Ui 20180216 patches Gerd Hoffmann
2018-02-16 11:54 ` Gerd Hoffmann [this message]
2018-02-16 11:54 ` [Qemu-devel] [PULL 2/9] vnc: add qapi/error.h include to stubs Gerd Hoffmann
2018-02-16 11:54 ` [Qemu-devel] [PULL 3/9] vnc: fix segfault in closed connection handling Gerd Hoffmann
2018-02-16 11:54 ` [Qemu-devel] [PULL 4/9] sdl: restore optimized redraw Gerd Hoffmann
2018-04-27 13:08 ` Peter Maydell
2018-02-16 11:54 ` [Qemu-devel] [PULL 5/9] sdl2: fix mouse grab Gerd Hoffmann
2018-02-16 11:54 ` [Qemu-devel] [PULL 6/9] ui: avoid risk of 32-bit int overflow in VNC buffer check Gerd Hoffmann
2018-02-16 11:54 ` [Qemu-devel] [PULL 7/9] ui: avoid 'local_err' variable shadowing in VNC SASL auth Gerd Hoffmann
2018-02-16 11:54 ` [Qemu-devel] [PULL 8/9] ui: check VNC audio frequency limit at time of reading from client Gerd Hoffmann
2018-02-16 11:54 ` [Qemu-devel] [PULL 9/9] ui: extend VNC trottling tracing to SASL codepaths Gerd Hoffmann
2018-02-16 16:46 ` [Qemu-devel] [PULL 0/9] Ui 20180216 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216115410.27287-2-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).