From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emin5-0003VE-A5 for qemu-devel@nongnu.org; Fri, 16 Feb 2018 11:23:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emimz-0000Dx-So for qemu-devel@nongnu.org; Fri, 16 Feb 2018 11:23:15 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:49182 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1emimz-0000DR-72 for qemu-devel@nongnu.org; Fri, 16 Feb 2018 11:23:09 -0500 Date: Fri, 16 Feb 2018 16:23:05 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20180216162304.GA2309@work-vm> References: <20180213125143.23488-1-dgilbert@redhat.com> <20180216155651.GA17727@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180216155651.GA17727@stefanha-x1.localdomain> Subject: Re: [Qemu-devel] [PATCH] monitor.c: Fix infinite loop in monitor's auto-complete List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, t.pagef.lt@gmail.com, qemu-devel@nongnu.org * Stefan Hajnoczi (stefanha@gmail.com) wrote: > On Tue, Feb 13, 2018 at 12:51:43PM +0000, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Please include the details of how to trigger this bug. This helps > justify the patch as well as aiding anyone investigating/backporting the > same issue in the future. OK, I'll include Dimitris's: The QEMU monitor enters an infinite loop when trying to auto-complete commands that accept only optional parameters. The commands currently affected by this issue are 'info registers' and 'info mtree'. > Aside from that: > Reviewed-by: Stefan Hajnoczi Thanks! Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK