Re: [Qemu-devel] [PATCH v9 14/29] hmp: add 'info sev' command

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Brijesh Singh (brijesh.singh@amd.com) wrote:
> The command can be used to show the SEV information when memory
> encryption is enabled on AMD platform.
> 
> Cc: Eric Blake <eblake@redhat.com>
> Cc: "Daniel P. Berrangé" <berrange@redhat.com>
> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>

That's ok, you might like to add something to decode the policy into a
human readable form.

You might also want to ifdef it for x86 (like info lapic).

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  hmp-commands-info.hx | 14 ++++++++++++++
>  hmp.c                | 19 +++++++++++++++++++
>  hmp.h                |  1 +
>  3 files changed, 34 insertions(+)
> 
> diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
> index ad590a4ffb2b..236811c465d2 100644
> --- a/hmp-commands-info.hx
> +++ b/hmp-commands-info.hx
> @@ -865,6 +865,20 @@ STEXI
>  @findex info memory_size_summary
>  Display the amount of initially allocated and present hotpluggable (if
>  enabled) memory in bytes.
> +ETEXI
> +
> +    {
> +        .name       = "sev",
> +        .args_type  = "",
> +        .params     = "",
> +        .help       = "show SEV information",
> +        .cmd        = hmp_info_sev,
> +    },
> +
> +STEXI
> +@item info sev
> +@findex info sev
> +Show SEV information.
>  ETEXI
>  
>  STEXI
> diff --git a/hmp.c b/hmp.c
> index 7870d6a3004e..f51a107a9be3 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -2924,3 +2924,22 @@ void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict)
>      }
>      hmp_handle_error(mon, &err);
>  }
> +
> +void hmp_info_sev(Monitor *mon, const QDict *qdict)
> +{
> +    SevInfo *info;
> +
> +    info = qmp_query_sev(NULL);
> +    monitor_printf(mon, "sev support: ");
> +    monitor_printf(mon, "%s\n", info->enabled ? "enabled" : "disabled");
> +
> +    if (info->enabled) {
> +        monitor_printf(mon, "state: %s\n", SevState_str(info->state));
> +        monitor_printf(mon, "policy: 0x%x\n", info->policy);
> +        monitor_printf(mon, "build id: %u\n", info->build_id);
> +        monitor_printf(mon, "api version: %u.%u\n",
> +                       info->api_major, info->api_minor);
> +    }
> +
> +    qapi_free_SevInfo(info);
> +}
> diff --git a/hmp.h b/hmp.h
> index 1143db44a760..4ca1a77b2c1f 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -146,5 +146,6 @@ void hmp_info_ramblock(Monitor *mon, const QDict *qdict);
>  void hmp_hotpluggable_cpus(Monitor *mon, const QDict *qdict);
>  void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict);
>  void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict);
> +void hmp_info_sev(Monitor *mon, const QDict *qdict);
>  
>  #endif
> -- 
> 2.14.3
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK