From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emjNv-00082A-4j for qemu-devel@nongnu.org; Fri, 16 Feb 2018 12:01:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emjNq-0008Hi-Ba for qemu-devel@nongnu.org; Fri, 16 Feb 2018 12:01:19 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:48174 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1emjNq-0008HW-5u for qemu-devel@nongnu.org; Fri, 16 Feb 2018 12:01:14 -0500 Date: Fri, 16 Feb 2018 17:01:07 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20180216170106.GE2308@work-vm> References: <20180215153955.3253-1-brijesh.singh@amd.com> <20180215153955.3253-15-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180215153955.3253-15-brijesh.singh@amd.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v9 14/29] hmp: add 'info sev' command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brijesh Singh Cc: qemu-devel@nongnu.org, Alistair Francis , Christian Borntraeger , Cornelia Huck , "Daniel P . Berrange" , "Michael S. Tsirkin" , "Edgar E. Iglesias" , Eduardo Habkost , Eric Blake , kvm@vger.kernel.org, Marcel Apfelbaum , Markus Armbruster , Paolo Bonzini , Peter Crosthwaite , Peter Maydell , Richard Henderson , Stefan Hajnoczi , Thomas Lendacky , Borislav Petkov , Alexander Graf , Bruce Rogers * Brijesh Singh (brijesh.singh@amd.com) wrote: > The command can be used to show the SEV information when memory > encryption is enabled on AMD platform. >=20 > Cc: Eric Blake > Cc: "Daniel P. Berrang=E9" > Cc: "Dr. David Alan Gilbert" > Cc: Markus Armbruster > Signed-off-by: Brijesh Singh That's ok, you might like to add something to decode the policy into a human readable form. You might also want to ifdef it for x86 (like info lapic). Reviewed-by: Dr. David Alan Gilbert > --- > hmp-commands-info.hx | 14 ++++++++++++++ > hmp.c | 19 +++++++++++++++++++ > hmp.h | 1 + > 3 files changed, 34 insertions(+) >=20 > diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx > index ad590a4ffb2b..236811c465d2 100644 > --- a/hmp-commands-info.hx > +++ b/hmp-commands-info.hx > @@ -865,6 +865,20 @@ STEXI > @findex info memory_size_summary > Display the amount of initially allocated and present hotpluggable (if > enabled) memory in bytes. > +ETEXI > + > + { > + .name =3D "sev", > + .args_type =3D "", > + .params =3D "", > + .help =3D "show SEV information", > + .cmd =3D hmp_info_sev, > + }, > + > +STEXI > +@item info sev > +@findex info sev > +Show SEV information. > ETEXI > =20 > STEXI > diff --git a/hmp.c b/hmp.c > index 7870d6a3004e..f51a107a9be3 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -2924,3 +2924,22 @@ void hmp_info_memory_size_summary(Monitor *mon, = const QDict *qdict) > } > hmp_handle_error(mon, &err); > } > + > +void hmp_info_sev(Monitor *mon, const QDict *qdict) > +{ > + SevInfo *info; > + > + info =3D qmp_query_sev(NULL); > + monitor_printf(mon, "sev support: "); > + monitor_printf(mon, "%s\n", info->enabled ? "enabled" : "disabled"= ); > + > + if (info->enabled) { > + monitor_printf(mon, "state: %s\n", SevState_str(info->state)); > + monitor_printf(mon, "policy: 0x%x\n", info->policy); > + monitor_printf(mon, "build id: %u\n", info->build_id); > + monitor_printf(mon, "api version: %u.%u\n", > + info->api_major, info->api_minor); > + } > + > + qapi_free_SevInfo(info); > +} > diff --git a/hmp.h b/hmp.h > index 1143db44a760..4ca1a77b2c1f 100644 > --- a/hmp.h > +++ b/hmp.h > @@ -146,5 +146,6 @@ void hmp_info_ramblock(Monitor *mon, const QDict *q= dict); > void hmp_hotpluggable_cpus(Monitor *mon, const QDict *qdict); > void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict); > void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict); > +void hmp_info_sev(Monitor *mon, const QDict *qdict); > =20 > #endif > --=20 > 2.14.3 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK