From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: stefanha@redhat.com, mst@redhat.com, mlureau@redhat.com,
qemu-devel@nongnu.org
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [Qemu-devel] [RFC 3/5] vhost_net: send virtio device status update to the backend
Date: Fri, 16 Feb 2018 18:29:08 +0100 [thread overview]
Message-ID: <20180216172910.8549-4-maxime.coquelin@redhat.com> (raw)
In-Reply-To: <20180216172910.8549-1-maxime.coquelin@redhat.com>
This patch adds ans uses a new function to send virtio device
status updates to the backend.
Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
hw/net/vhost_net.c | 10 ++++++++++
hw/net/virtio-net.c | 7 ++++++-
include/net/vhost_net.h | 2 ++
3 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
index e037db63a3..75e2165163 100644
--- a/hw/net/vhost_net.c
+++ b/hw/net/vhost_net.c
@@ -450,6 +450,11 @@ int vhost_net_set_mtu(struct vhost_net *net, uint16_t mtu)
return vhost_ops->vhost_net_set_mtu(&net->dev, mtu);
}
+int vhost_net_set_virtio_status(struct vhost_net *net, uint8_t status)
+{
+ return vhost_dev_set_virtio_status(&net->dev, status);
+}
+
#else
uint64_t vhost_net_get_max_queues(VHostNetState *net)
{
@@ -521,4 +526,9 @@ int vhost_net_set_mtu(struct vhost_net *net, uint16_t mtu)
{
return 0;
}
+
+int vhost_net_set_virtio_status(struct vhost_net *net, uint8_t status)
+{
+ return 0;
+}
#endif
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 38674b08aa..06c431ea28 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -136,7 +136,7 @@ static void virtio_net_vhost_status(VirtIONet *n, uint8_t status)
if ((virtio_net_started(n, status) && !nc->peer->link_down) ==
!!n->vhost_started) {
- return;
+ goto out;
}
if (!n->vhost_started) {
int r, i;
@@ -175,11 +175,16 @@ static void virtio_net_vhost_status(VirtIONet *n, uint8_t status)
error_report("unable to start vhost net: %d: "
"falling back on userspace virtio", -r);
n->vhost_started = 0;
+
+ return;
}
} else {
vhost_net_stop(vdev, n->nic->ncs, queues);
n->vhost_started = 0;
}
+
+out:
+ vhost_net_set_virtio_status(get_vhost_net(nc->peer), status);
}
static int virtio_net_set_vnet_endian_one(VirtIODevice *vdev,
diff --git a/include/net/vhost_net.h b/include/net/vhost_net.h
index afc1499eb9..bf083e2d2e 100644
--- a/include/net/vhost_net.h
+++ b/include/net/vhost_net.h
@@ -37,4 +37,6 @@ uint64_t vhost_net_get_acked_features(VHostNetState *net);
int vhost_net_set_mtu(struct vhost_net *net, uint16_t mtu);
+int vhost_net_set_virtio_status(struct vhost_net *net, uint8_t status);
+
#endif
--
2.14.3
next prev parent reply other threads:[~2018-02-16 17:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 17:29 [Qemu-devel] [RFC 0/5] vhost-user: Forward virtio device status updates Maxime Coquelin
2018-02-16 17:29 ` [Qemu-devel] [RFC 1/5] vhost: send virtio device status update to the backend Maxime Coquelin
2018-02-16 17:29 ` [Qemu-devel] [RFC 2/5] vhost-user: Introduce new request to send virtio device status Maxime Coquelin
2018-02-27 15:01 ` Michael S. Tsirkin
2018-02-27 16:30 ` Maxime Coquelin
2018-02-16 17:29 ` Maxime Coquelin [this message]
2018-02-16 17:29 ` [Qemu-devel] [RFC 4/5] vhost-user-blk: send virtio status to the backend Maxime Coquelin
2018-02-16 17:29 ` [Qemu-devel] [RFC 5/5] vhost-user-scsi: " Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216172910.8549-4-maxime.coquelin@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=mlureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).