From: Michael Davidsaver <mdavidsaver@gmail.com>
To: Paul Brook <paul@codesourcery.com>,
Peter Maydell <peter.maydell@linaro.org>,
Antoine Mathys <barsamin@gmail.com>
Cc: David Gibson <david@gibson.dropbear.id.au>,
qemu-devel@nongnu.org, Michael Davidsaver <mdavidsaver@gmail.com>
Subject: [Qemu-devel] [PATCH 0/5] Generalize Dallas/Maxim I2C RTC devices
Date: Sun, 18 Feb 2018 20:03:37 -0800 [thread overview]
Message-ID: <20180219040342.12686-1-mdavidsaver@gmail.com> (raw)
These changes previously appeared as part of a series "Add MVME3100 PPC SBC v2"
back in November. David Gibson, who looked that that series, suggested getting
this reviewed separately. There doesn't appear to be a listed maintainer
for this code, so I'm addressing this to the 3 people who have made more than
cosmetic changes to it. The most recent of these was in 2012.
This series replaces the ds1338 RTC with a model covering a number of these
similar chips: ds1307, ds1337, ds1338, ds1339, ds1340, ds1375, ds1388,
and ds3231.
The limits of the new model are the same as the old. Only the time of day
registers, and NVRAM are modeled. The alarm and control registers are not.
I've added a more thorough test of the time of day function, covering
reading and setting in both 12 and 24 hour mode. In the process
I found two minor issues with the ds1338 model. These are described in the
commit message for #3. So this series first adds those tests which pass with
both old and new model. Then later adds some additional tests which only
pass with the new model.
Michael Davidsaver (5):
timer: ds1338 add magic reset for test code
tests: more thorough test of ds1338
timer: generalize Dallas/Maxim RTC i2c devices
tests: ds-rtc-i2c-test test 12 hour mode and DoW
tests: drop ds1338-test
default-configs/arm-softmmu.mak | 2 +-
hw/timer/Makefile.objs | 2 +-
hw/timer/ds-rtc-i2c.c | 466 ++++++++++++++++++++++++++++++++++++++++
hw/timer/ds1338.c | 239 ---------------------
tests/Makefile.include | 4 +-
tests/ds-rtc-i2c-test.c | 245 +++++++++++++++++++++
tests/ds1338-test.c | 75 -------
7 files changed, 715 insertions(+), 318 deletions(-)
create mode 100644 hw/timer/ds-rtc-i2c.c
delete mode 100644 hw/timer/ds1338.c
create mode 100644 tests/ds-rtc-i2c-test.c
delete mode 100644 tests/ds1338-test.c
--
2.11.0
next reply other threads:[~2018-02-19 4:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 4:03 Michael Davidsaver [this message]
2018-02-19 4:03 ` [Qemu-devel] [PATCH 1/5] timer: ds1338 add magic reset for test code Michael Davidsaver
2018-02-19 4:03 ` [Qemu-devel] [PATCH 2/5] tests: more thorough test of ds1338 Michael Davidsaver
2018-02-19 7:39 ` Thomas Huth
2018-02-20 17:44 ` Michael Davidsaver
2018-03-24 19:39 ` Michael Davidsaver
2018-04-05 10:15 ` Thomas Huth
2018-02-19 4:03 ` [Qemu-devel] [PATCH 3/5] timer: generalize Dallas/Maxim RTC i2c devices Michael Davidsaver
2018-02-22 17:13 ` Peter Maydell
2018-02-19 4:03 ` [Qemu-devel] [PATCH 4/5] tests: ds-rtc-i2c-test test 12 hour mode and DoW Michael Davidsaver
2018-02-19 4:03 ` [Qemu-devel] [PATCH 5/5] tests: drop ds1338-test Michael Davidsaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180219040342.12686-1-mdavidsaver@gmail.com \
--to=mdavidsaver@gmail.com \
--cc=barsamin@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).