Re: [Qemu-devel] [PATCH v4 0/7] vfio: add display support

[Alex Williamson <alex.williamson@redhat.com>]

On Mon, 19 Feb 2018 12:14:51 +0100
Gerd Hoffmann <kraxel@redhat.com> wrote:

> This series adds support for a vgpu display to the qemu vfio code.
> For now only regions are supported, dmabufs will follow later.
> 
> This version adds a patch to allow devices disable hotplugging, which
> will be used by vfio display support.  Also fixed issues Alex found in
> review.

Looks ok to me, if this is to go through my tree I'll need a qdev ack
for 4/7.  If you want to go a different route, for 5-7:

Acked-by: Alex Williamson <alex.williamson@redhat.com>

I'm still a bit confused though, what's preventing us from adding
dmabuf support now?  It's strange to provide the implementation for the
proprietary, unavailable vendor driver implementation first.  Is GVT-g
broken, lagging?  Thanks,

Alex


> Gerd Hoffmann (7):
>   linux-headers: update to 4.16-rc1
>   standard-headers: add drm/drm_fourcc.h
>   ui/pixman: add qemu_drm_format_to_pixman()
>   qdev: add hotpluggable to DeviceState
>   vfio/common: cleanup in vfio_region_finalize
>   vfio/display: core & wireup
>   vfio/display: adding region support
> 
>  hw/vfio/pci.h                                      |   4 +
>  include/hw/qdev-core.h                             |   1 +
>  include/hw/vfio/vfio-common.h                      |   8 +
>  include/standard-headers/drm/drm_fourcc.h          | 411 +++++++++++++++++++++
>  include/standard-headers/linux/input-event-codes.h |   1 +
>  include/standard-headers/linux/input.h             |  11 +
>  include/standard-headers/linux/pci_regs.h          |  30 +-
>  include/standard-headers/linux/virtio_net.h        |  13 +
>  include/ui/qemu-pixman.h                           |   5 +
>  linux-headers/asm-powerpc/kvm.h                    |   2 +
>  linux-headers/asm-powerpc/unistd.h                 |   3 +
>  linux-headers/asm-s390/unistd.h                    | 401 +-------------------
>  linux-headers/asm-s390/unistd_32.h                 | 364 ++++++++++++++++++
>  linux-headers/asm-s390/unistd_64.h                 | 331 +++++++++++++++++
>  linux-headers/asm-x86/kvm_para.h                   |   4 +
>  linux-headers/linux/kvm.h                          |  90 +++++
>  linux-headers/linux/psci.h                         |   3 +
>  linux-headers/linux/vfio.h                         |  72 ++++
>  hw/core/qdev.c                                     |   5 +-
>  hw/vfio/common.c                                   |   7 +
>  hw/vfio/display.c                                  | 152 ++++++++
>  hw/vfio/pci.c                                      |   9 +
>  ui/qemu-pixman.c                                   |  22 ++
>  hw/vfio/Makefile.objs                              |   2 +-
>  scripts/update-linux-headers.sh                    |   7 +
>  25 files changed, 1545 insertions(+), 413 deletions(-)
>  create mode 100644 include/standard-headers/drm/drm_fourcc.h
>  create mode 100644 linux-headers/asm-s390/unistd_32.h
>  create mode 100644 linux-headers/asm-s390/unistd_64.h
>  create mode 100644 hw/vfio/display.c
>