qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Riku Voipio" <riku.voipio@iki.fi>,
	"Guido Günther" <agx@sigxcpu.org>,
	"Laurent Vivier" <laurent@vivier.eu>
Subject: [Qemu-devel] [PULL 2/8] linux-user: Fix register used for 6th and 7th syscall argument on aarch64
Date: Mon, 19 Feb 2018 18:10:31 +0100	[thread overview]
Message-ID: <20180219171037.24539-3-laurent@vivier.eu> (raw)
In-Reply-To: <20180219171037.24539-1-laurent@vivier.eu>

From: Guido Günther <agx@sigxcpu.org>

This unbreaks the testcase from

    http://lists.nongnu.org/archive/html/qemu-arm/2018-01/msg00514.html

Thanks to Laurent Vivier for spotting the 7th one.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Suggested-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <671eaa99f4e0bf3a58f76f9151f7cfa24662227f.1517565566.git.agx@sigxcpu.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/host/aarch64/safe-syscall.inc.S | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/linux-user/host/aarch64/safe-syscall.inc.S b/linux-user/host/aarch64/safe-syscall.inc.S
index 58a2329b37..bc1f5a9792 100644
--- a/linux-user/host/aarch64/safe-syscall.inc.S
+++ b/linux-user/host/aarch64/safe-syscall.inc.S
@@ -36,7 +36,7 @@ safe_syscall_base:
 	 *               and return the result in x0
 	 * and the syscall instruction needs
 	 *               x8 == syscall number
-	 *               x0 ... x7 == syscall arguments
+	 *               x0 ... x6 == syscall arguments
 	 *               and returns the result in x0
 	 * Shuffle everything around appropriately.
 	 */
@@ -47,8 +47,8 @@ safe_syscall_base:
 	mov	x2, x4
 	mov	x3, x5
 	mov	x4, x6
-	mov	x6, x7
-	ldr	x7, [sp]
+	mov	x5, x7
+	ldr	x6, [sp]
 
 	/* This next sequence of code works in conjunction with the
 	 * rewind_if_safe_syscall_function(). If a signal is taken
-- 
2.14.3

  parent reply	other threads:[~2018-02-19 17:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19 17:10 [Qemu-devel] [PULL 0/8] Linux user for 2.12 patches Laurent Vivier
2018-02-19 17:10 ` [Qemu-devel] [PULL 1/8] linux-user: Implement ioctl cmd TIOCGPTPEER Laurent Vivier
2018-02-19 17:10 ` Laurent Vivier [this message]
2018-02-19 17:10 ` [Qemu-devel] [PULL 3/8] linux-user: Fix sched_getaffinity mask size Laurent Vivier
2018-02-19 17:10 ` [Qemu-devel] [PULL 4/8] linux-user: Remove THREAD macro Laurent Vivier
2018-02-19 17:10 ` [Qemu-devel] [PULL 5/8] linux-user: Move CPU type name selection to a function Laurent Vivier
2018-02-19 17:10 ` [Qemu-devel] [PULL 6/8] linux-user: introduce functions to detect CPU type Laurent Vivier
2018-02-19 17:10 ` [Qemu-devel] [PULL 7/8] linux-user, m68k: select CPU according to ELF header values Laurent Vivier
2018-02-19 17:10 ` [Qemu-devel] [PULL 8/8] linux-user: MIPS set cpu to r6 CPU if binary is R6 Laurent Vivier
2018-02-19 19:50 ` [Qemu-devel] [PULL 0/8] Linux user for 2.12 patches Peter Maydell
2018-02-20  9:13   ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180219171037.24539-3-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=agx@sigxcpu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).