From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 12/12] ui: Reorder vte terminal packing to avoid gtk3 warnings
Date: Tue, 20 Feb 2018 14:47:23 +0100 [thread overview]
Message-ID: <20180220134723.11776-13-kraxel@redhat.com> (raw)
In-Reply-To: <20180220134723.11776-1-kraxel@redhat.com>
From: Jan Kiszka <jan.kiszka@siemens.com>
Fill the terminal box from right to left to avoid
Gtk-WARNING **: Allocating size to GtkScrollbar 0x55f6d54b0200 without
calling gtk_widget_get_preferred_width/height(). How does the code
know the size to allocate?
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Message-id: 902aaef8-d20e-0530-dea2-cdfe3db33ff3@web.de
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/gtk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index ad4910c70d..ab646b70e1 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1952,8 +1952,8 @@ static GSList *gd_vc_vte_init(GtkDisplayState *s, VirtualConsole *vc,
scrollbar = gtk_vscrollbar_new(vadjustment);
#endif
- gtk_box_pack_start(GTK_BOX(box), vc->vte.terminal, TRUE, TRUE, 0);
- gtk_box_pack_start(GTK_BOX(box), scrollbar, FALSE, FALSE, 0);
+ gtk_box_pack_end(GTK_BOX(box), scrollbar, FALSE, FALSE, 0);
+ gtk_box_pack_end(GTK_BOX(box), vc->vte.terminal, TRUE, TRUE, 0);
vc->vte.box = box;
vc->vte.scrollbar = scrollbar;
--
2.9.3
next prev parent reply other threads:[~2018-02-20 13:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 13:47 [Qemu-devel] [PULL 00/12] Ui 20180220 patches Gerd Hoffmann
2018-02-20 13:47 ` [Qemu-devel] [PULL 01/12] vl: deprecate -no-frame Gerd Hoffmann
2018-02-20 13:47 ` [Qemu-devel] [PULL 02/12] vl: rename DisplayType to LegacyDisplayType Gerd Hoffmann
2018-02-20 13:47 ` [Qemu-devel] [PULL 03/12] gtk: add and use DisplayOptions + DisplayGTK Gerd Hoffmann
2018-02-20 13:47 ` [Qemu-devel] [PULL 04/12] sdl: use DisplayOptions Gerd Hoffmann
2018-02-20 13:47 ` [Qemu-devel] [PULL 05/12] vl: drop no_quit variable Gerd Hoffmann
2018-02-20 13:47 ` [Qemu-devel] [PULL 06/12] egl-headless: use DisplayOptions Gerd Hoffmann
2018-02-20 13:47 ` [Qemu-devel] [PULL 07/12] curses: " Gerd Hoffmann
2018-02-20 13:47 ` [Qemu-devel] [PULL 08/12] cocoa: " Gerd Hoffmann
2018-02-20 13:47 ` [Qemu-devel] [PULL 09/12] vl: drop full_screen variable Gerd Hoffmann
2018-02-20 13:47 ` [Qemu-devel] [PULL 10/12] vl: drop request_opengl variable Gerd Hoffmann
2018-02-20 13:47 ` [Qemu-devel] [PULL 11/12] vl: drop display_type variable Gerd Hoffmann
2018-02-20 13:47 ` Gerd Hoffmann [this message]
2018-02-20 15:38 ` [Qemu-devel] [PULL 00/12] Ui 20180220 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220134723.11776-13-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).