From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH v2 4/5] keymap: record multiple keysym -> keycode mappings
Date: Tue, 20 Feb 2018 16:03:56 +0100 [thread overview]
Message-ID: <20180220150357.324-5-kraxel@redhat.com> (raw)
In-Reply-To: <20180220150357.324-1-kraxel@redhat.com>
Sometimes the same keysym can be created using different key
combinations. Record them all in the reverse keymap, not only
the first one.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/keymaps.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/ui/keymaps.c b/ui/keymaps.c
index d71ae389e0..26a85ff207 100644
--- a/ui/keymaps.c
+++ b/ui/keymaps.c
@@ -29,7 +29,8 @@
#include "qemu/error-report.h"
struct keysym2code {
- uint16_t keycode;
+ uint32_t count;
+ uint16_t keycodes[4];
};
struct kbd_layout_t {
@@ -68,11 +69,18 @@ static void add_keysym(char *line, int keysym, int keycode, kbd_layout_t *k)
keysym2code = g_hash_table_lookup(k->hash, hashkey(keysym));
if (keysym2code) {
+ if (keysym2code->count < ARRAY_SIZE(keysym2code->keycodes)) {
+ keysym2code->keycodes[keysym2code->count++] = keycode;
+ } else {
+ warn_report("more than %zd keycodes for keysym %d",
+ ARRAY_SIZE(keysym2code->keycodes), keysym);
+ }
return;
}
keysym2code = g_new0(struct keysym2code, 1);
- keysym2code->keycode = keycode;
+ keysym2code->keycodes[0] = keycode;
+ keysym2code->count = 1;
g_hash_table_replace(k->hash, hashkey(keysym), keysym2code);
trace_keymap_add(keysym, keycode, line);
}
@@ -191,7 +199,7 @@ int keysym2scancode(kbd_layout_t *k, int keysym)
return 0;
}
- return keysym2code->keycode;
+ return keysym2code->keycodes[0];
}
int keycode_is_keypad(kbd_layout_t *k, int keycode)
--
2.9.3
next prev parent reply other threads:[~2018-02-20 15:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 15:03 [Qemu-devel] [PATCH v2 0/5] keymap: support kbd layouts with multiple mappings for the same key Gerd Hoffmann
2018-02-20 15:03 ` [Qemu-devel] [PATCH v2 1/5] keymap: make struct kbd_layout_t private to ui/keymaps.c Gerd Hoffmann
2018-02-21 14:34 ` Daniel P. Berrangé
2018-02-20 15:03 ` [Qemu-devel] [PATCH v2 2/5] keymap: use glib hash for kbd_layout_t Gerd Hoffmann
2018-02-21 14:38 ` Daniel P. Berrangé
2018-02-20 15:03 ` [Qemu-devel] [PATCH v2 3/5] keymap: numpad keysyms and keycodes are fixed Gerd Hoffmann
2018-02-21 14:40 ` Daniel P. Berrangé
2018-02-20 15:03 ` Gerd Hoffmann [this message]
2018-02-21 14:42 ` [Qemu-devel] [PATCH v2 4/5] keymap: record multiple keysym -> keycode mappings Daniel P. Berrangé
2018-02-20 15:03 ` [Qemu-devel] [PATCH v2 5/5] keymap: consider modifier state when picking a mapping Gerd Hoffmann
2018-02-21 14:44 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220150357.324-5-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).