Re: [Qemu-devel] [PATCH] Document --rtc-td-hack, --localtime and --startdate as deprecated

Re: [Qemu-devel] [PATCH] Document --rtc-td-hack, --localtime and --startdate as deprecated

[Paolo Bonzini]

On 20/02/2018 16:01, Thomas Huth wrote:
> These options have been marked in a comment in qemu-options.hx as
> deprecated in 2009 already (see commit 1ed2fc1fa35fadc0d6), but we
> never informed the users about these deprecations. Let's catch up
> on that omission now.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  qemu-doc.texi | 13 +++++++++++++
>  vl.c          |  5 +++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index 2f19980..7494042 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -2736,6 +2736,19 @@ filesystem test suite. Also it requires the CAP_DAC_READ_SEARCH capability,
>  which is not the recommended way to run QEMU. This backend should not be
>  used and it will be removed with no replacement.
>  
> +@subsection -rtc-td-hack (since 2.12.0)
> +
> +The @code{--rtc-td-hack} option has been replaced by
> +@code{--rtc driftfix=slew}.
> +
> +@subsection -localtime (since 2.12.0)
> +
> +The @code{--localtime} option has been replaced by @code{--rtc localtime}.
> +
> +@subsection -startdate (since 2.12.0)
> +
> +The @code{--startdate} option has been replaced by @code{--rtc @var{date}}.
> +
>  @section qemu-img command line arguments
>  
>  @subsection convert -s (since 2.0.0)
> diff --git a/vl.c b/vl.c
> index 0feaca7..84121bf 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3417,6 +3417,8 @@ int main(int argc, char **argv, char **envp)
>                  break;
>              case QEMU_OPTION_localtime:
>                  rtc_utc = 0;
> +                warn_report("This option is deprecated, "
> +                            "use '--rtc localtime' instead.");
>                  break;
>              case QEMU_OPTION_vga:
>                  vga_model = optarg;
> @@ -3672,6 +3674,8 @@ int main(int argc, char **argv, char **envp)
>                  };
>  
>                  qdev_prop_register_global(&slew_lost_ticks);
> +                warn_report("This option is deprecated, "
> +                            "use '--rtc driftfix=slew' instead.");
>                  break;
>              }
>              case QEMU_OPTION_acpitable:
> @@ -3876,6 +3880,7 @@ int main(int argc, char **argv, char **envp)
>                   */
>                  break;
>              case QEMU_OPTION_startdate:
> +                warn_report("This option is deprecated, use '--rtc' instead.");
>                  configure_rtc_date_offset(optarg, 1);
>                  break;
>              case QEMU_OPTION_rtc:
> 

Queued, thanks.

paolo

Re: [Qemu-devel] [PATCH] Document --rtc-td-hack, --localtime and --startdate as deprecated

[Paolo Bonzini]

On 20/02/2018 16:05, Paolo Bonzini wrote:
> On 20/02/2018 16:01, Thomas Huth wrote:
>> These options have been marked in a comment in qemu-options.hx as
>> deprecated in 2009 already (see commit 1ed2fc1fa35fadc0d6), but we
>> never informed the users about these deprecations. Let's catch up
>> on that omission now.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  qemu-doc.texi | 13 +++++++++++++
>>  vl.c          |  5 +++++
>>  2 files changed, 18 insertions(+)
>>
>> diff --git a/qemu-doc.texi b/qemu-doc.texi
>> index 2f19980..7494042 100644
>> --- a/qemu-doc.texi
>> +++ b/qemu-doc.texi
>> @@ -2736,6 +2736,19 @@ filesystem test suite. Also it requires the CAP_DAC_READ_SEARCH capability,
>>  which is not the recommended way to run QEMU. This backend should not be
>>  used and it will be removed with no replacement.
>>  
>> +@subsection -rtc-td-hack (since 2.12.0)
>> +
>> +The @code{--rtc-td-hack} option has been replaced by
>> +@code{--rtc driftfix=slew}.
>> +
>> +@subsection -localtime (since 2.12.0)
>> +
>> +The @code{--localtime} option has been replaced by @code{--rtc localtime}.
>> +
>> +@subsection -startdate (since 2.12.0)
>> +
>> +The @code{--startdate} option has been replaced by @code{--rtc @var{date}}.
>> +
>>  @section qemu-img command line arguments
>>  
>>  @subsection convert -s (since 2.0.0)
>> diff --git a/vl.c b/vl.c
>> index 0feaca7..84121bf 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -3417,6 +3417,8 @@ int main(int argc, char **argv, char **envp)
>>                  break;
>>              case QEMU_OPTION_localtime:
>>                  rtc_utc = 0;
>> +                warn_report("This option is deprecated, "
>> +                            "use '--rtc localtime' instead.");
>>                  break;
>>              case QEMU_OPTION_vga:
>>                  vga_model = optarg;
>> @@ -3672,6 +3674,8 @@ int main(int argc, char **argv, char **envp)
>>                  };
>>  
>>                  qdev_prop_register_global(&slew_lost_ticks);
>> +                warn_report("This option is deprecated, "
>> +                            "use '--rtc driftfix=slew' instead.");
>>                  break;
>>              }
>>              case QEMU_OPTION_acpitable:
>> @@ -3876,6 +3880,7 @@ int main(int argc, char **argv, char **envp)
>>                   */
>>                  break;
>>              case QEMU_OPTION_startdate:
>> +                warn_report("This option is deprecated, use '--rtc' instead.");
>>                  configure_rtc_date_offset(optarg, 1);
>>                  break;
>>              case QEMU_OPTION_rtc:
> 
> Queued, thanks.

... except qemu_rtc_opts has no implied_opt_name, soo it's "-rtc base".
I fixed that up.

Paolo

Re: [Qemu-devel] [PATCH] Document --rtc-td-hack, --localtime and --startdate as deprecated

[Daniel P. Berrangé]

On Tue, Feb 20, 2018 at 04:01:32PM +0100, Thomas Huth wrote:
> These options have been marked in a comment in qemu-options.hx as
> deprecated in 2009 already (see commit 1ed2fc1fa35fadc0d6), but we
> never informed the users about these deprecations. Let's catch up
> on that omission now.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  qemu-doc.texi | 13 +++++++++++++
>  vl.c          |  5 +++++
>  2 files changed, 18 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|