From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [Qemu-devel] [PULL 02/22] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES
Date: Wed, 21 Feb 2018 11:05:02 +0000 [thread overview]
Message-ID: <20180221110523.859-3-alex.bennee@linaro.org> (raw)
In-Reply-To: <20180221110523.859-1-alex.bennee@linaro.org>
It's not actively built and when enabled things fail to compile. I'm
not sure the type-checking is really helping here. Seeing as we "own"
our softfloat now lets remove the cruft.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h
index d5e99667b6..52af1412de 100644
--- a/include/fpu/softfloat.h
+++ b/include/fpu/softfloat.h
@@ -103,32 +103,6 @@ enum {
/*----------------------------------------------------------------------------
| Software IEC/IEEE floating-point types.
*----------------------------------------------------------------------------*/
-/* Use structures for soft-float types. This prevents accidentally mixing
- them with native int/float types. A sufficiently clever compiler and
- sane ABI should be able to see though these structs. However
- x86/gcc 3.x seems to struggle a bit, so leave them disabled by default. */
-//#define USE_SOFTFLOAT_STRUCT_TYPES
-#ifdef USE_SOFTFLOAT_STRUCT_TYPES
-typedef struct {
- uint16_t v;
-} float16;
-#define float16_val(x) (((float16)(x)).v)
-#define make_float16(x) __extension__ ({ float16 f16_val = {x}; f16_val; })
-#define const_float16(x) { x }
-typedef struct {
- uint32_t v;
-} float32;
-/* The cast ensures an error if the wrong type is passed. */
-#define float32_val(x) (((float32)(x)).v)
-#define make_float32(x) __extension__ ({ float32 f32_val = {x}; f32_val; })
-#define const_float32(x) { x }
-typedef struct {
- uint64_t v;
-} float64;
-#define float64_val(x) (((float64)(x)).v)
-#define make_float64(x) __extension__ ({ float64 f64_val = {x}; f64_val; })
-#define const_float64(x) { x }
-#else
typedef uint16_t float16;
typedef uint32_t float32;
typedef uint64_t float64;
@@ -141,7 +115,6 @@ typedef uint64_t float64;
#define const_float16(x) (x)
#define const_float32(x) (x)
#define const_float64(x) (x)
-#endif
typedef struct {
uint64_t low;
uint16_t high;
--
2.15.1
next prev parent reply other threads:[~2018-02-21 11:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 11:05 [Qemu-devel] [PULL 00/22] re-factor softfloat and add fp16 functions Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 01/22] fpu/softfloat: implement float16_squash_input_denormal Alex Bennée
2018-02-21 11:05 ` Alex Bennée [this message]
2018-02-21 11:05 ` [Qemu-devel] [PULL 03/22] fpu/softfloat-types: new header to prevent excessive re-builds Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 04/22] target/*/cpu.h: remove softfloat.h Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 05/22] include/fpu/softfloat: implement float16_abs helper Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 06/22] include/fpu/softfloat: implement float16_chs helper Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 07/22] include/fpu/softfloat: implement float16_set_sign helper Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 08/22] include/fpu/softfloat: add some float16 constants Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 09/22] fpu/softfloat: improve comments on ARM NaN propagation Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 10/22] fpu/softfloat: move the extract functions to the top of the file Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 11/22] fpu/softfloat: define decompose structures Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 12/22] fpu/softfloat: re-factor add/sub Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 13/22] fpu/softfloat: re-factor mul Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 14/22] fpu/softfloat: re-factor div Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 15/22] fpu/softfloat: re-factor muladd Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 16/22] fpu/softfloat: re-factor round_to_int Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 17/22] fpu/softfloat: re-factor float to int/uint Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 18/22] fpu/softfloat: re-factor int/uint to float Alex Bennée
2018-04-27 12:15 ` Peter Maydell
2018-04-27 13:49 ` Alex Bennée
2018-05-08 10:41 ` Peter Maydell
2018-05-08 10:54 ` Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 19/22] fpu/softfloat: re-factor scalbn Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 20/22] fpu/softfloat: re-factor minmax Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 21/22] fpu/softfloat: re-factor compare Alex Bennée
2018-02-21 11:05 ` [Qemu-devel] [PULL 22/22] fpu/softfloat: re-factor sqrt Alex Bennée
2018-02-22 11:36 ` [Qemu-devel] [PULL 00/22] re-factor softfloat and add fp16 functions Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221110523.859-3-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).