qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 07/12] console: add ui module loading support
Date: Wed, 21 Feb 2018 14:15:32 +0100	[thread overview]
Message-ID: <20180221131537.31341-8-kraxel@redhat.com> (raw)
In-Reply-To: <20180221131537.31341-1-kraxel@redhat.com>

If a requested user interface is not available, try loading it as
module, simliar to block layer modules.  Needed to keep things working
when followup patches start to build user interfaces as modules.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 include/qemu/module.h | 1 +
 ui/console.c          | 6 ++++++
 2 files changed, 7 insertions(+)

diff --git a/include/qemu/module.h b/include/qemu/module.h
index 56dd218205..9fea75aaeb 100644
--- a/include/qemu/module.h
+++ b/include/qemu/module.h
@@ -53,6 +53,7 @@ typedef enum {
 #define trace_init(function) module_init(function, MODULE_INIT_TRACE)
 
 #define block_module_load_one(lib) module_load_one("block-", lib)
+#define ui_module_load_one(lib) module_load_one("ui-", lib)
 
 void register_module_init(void (*fn)(void), module_init_type type);
 void register_dso_module_init(void (*fn)(void), module_init_type type);
diff --git a/ui/console.c b/ui/console.c
index 5a63e9dfa2..dd663b9127 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -2189,6 +2189,9 @@ bool qemu_display_find_default(DisplayOptions *opts)
 
     for (i = 0; i < ARRAY_SIZE(prio); i++) {
         if (dpys[prio[i]] == NULL) {
+            ui_module_load_one(DisplayType_lookup.array[prio[i]]);
+        }
+        if (dpys[prio[i]] == NULL) {
             continue;
         }
         opts->type = prio[i];
@@ -2204,6 +2207,9 @@ void qemu_display_early_init(DisplayOptions *opts)
         return;
     }
     if (dpys[opts->type] == NULL) {
+        ui_module_load_one(DisplayType_lookup.array[opts->type]);
+    }
+    if (dpys[opts->type] == NULL) {
         error_report("Display '%s' is not available.",
                      DisplayType_lookup.array[opts->type]);
         exit(1);
-- 
2.9.3

  parent reply	other threads:[~2018-02-21 13:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21 13:15 [Qemu-devel] [PATCH 00/12] ui: build sdl, gtk and curses as modules Gerd Hoffmann
2018-02-21 13:15 ` [Qemu-devel] [PATCH 01/12] console: add qemu display registry, add gtk Gerd Hoffmann
2018-02-21 13:15 ` [Qemu-devel] [PATCH 02/12] sdl: switch over to new display registry Gerd Hoffmann
2018-02-21 13:15 ` [Qemu-devel] [PATCH 03/12] cocoa: " Gerd Hoffmann
2018-02-21 13:15 ` [Qemu-devel] [PATCH 04/12] curses: " Gerd Hoffmann
2018-02-21 13:15 ` [Qemu-devel] [PATCH 05/12] egl-headless: " Gerd Hoffmann
2018-02-21 13:15 ` [Qemu-devel] [PATCH 06/12] console: add and use qemu_display_find_default Gerd Hoffmann
2018-02-21 13:15 ` Gerd Hoffmann [this message]
2018-02-21 13:15 ` [Qemu-devel] [PATCH 08/12] configure: add X11 vars to config-host.mak Gerd Hoffmann
2018-02-21 13:15 ` [Qemu-devel] [PATCH 09/12] configure: opengl doesn't depend on x11 Gerd Hoffmann
2018-02-21 13:15 ` [Qemu-devel] [PATCH 10/12] sdl: build as ui module Gerd Hoffmann
2018-02-21 13:15 ` [Qemu-devel] [PATCH 11/12] gtk: " Gerd Hoffmann
2018-02-21 13:15 ` [Qemu-devel] [PATCH 12/12] curses: " Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180221131537.31341-8-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).