From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 3/5] keymap: numpad keysyms and keycodes are fixed
Date: Wed, 21 Feb 2018 14:40:20 +0000 [thread overview]
Message-ID: <20180221144020.GX17096@redhat.com> (raw)
In-Reply-To: <20180220150357.324-4-kraxel@redhat.com>
On Tue, Feb 20, 2018 at 04:03:55PM +0100, Gerd Hoffmann wrote:
> No need to figure them at runtime from the keymap.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> ui/keymaps.c | 61 +++++++++---------------------------------------------------
> 1 file changed, 9 insertions(+), 52 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2018-02-21 14:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 15:03 [Qemu-devel] [PATCH v2 0/5] keymap: support kbd layouts with multiple mappings for the same key Gerd Hoffmann
2018-02-20 15:03 ` [Qemu-devel] [PATCH v2 1/5] keymap: make struct kbd_layout_t private to ui/keymaps.c Gerd Hoffmann
2018-02-21 14:34 ` Daniel P. Berrangé
2018-02-20 15:03 ` [Qemu-devel] [PATCH v2 2/5] keymap: use glib hash for kbd_layout_t Gerd Hoffmann
2018-02-21 14:38 ` Daniel P. Berrangé
2018-02-20 15:03 ` [Qemu-devel] [PATCH v2 3/5] keymap: numpad keysyms and keycodes are fixed Gerd Hoffmann
2018-02-21 14:40 ` Daniel P. Berrangé [this message]
2018-02-20 15:03 ` [Qemu-devel] [PATCH v2 4/5] keymap: record multiple keysym -> keycode mappings Gerd Hoffmann
2018-02-21 14:42 ` Daniel P. Berrangé
2018-02-20 15:03 ` [Qemu-devel] [PATCH v2 5/5] keymap: consider modifier state when picking a mapping Gerd Hoffmann
2018-02-21 14:44 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221144020.GX17096@redhat.com \
--to=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).