From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoWRd-0000W4-EB for qemu-devel@nongnu.org; Wed, 21 Feb 2018 10:36:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoWRZ-0004m7-AI for qemu-devel@nongnu.org; Wed, 21 Feb 2018 10:36:32 -0500 Date: Wed, 21 Feb 2018 16:36:25 +0100 From: Cornelia Huck Message-ID: <20180221163625.69dfe7de.cohuck@redhat.com> In-Reply-To: <1519152302-19079-1-git-send-email-imbrenda@linux.vnet.ibm.com> References: <1519152302-19079-1-git-send-email-imbrenda@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 0/3] s390x/sclp: 64 bit event masks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Claudio Imbrenda Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, borntraeger@de.ibm.com On Tue, 20 Feb 2018 19:44:59 +0100 Claudio Imbrenda wrote: > Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length event masks") > we only supported 32bit sclp event masks, even though the archiecture > allows the guests to set up sclp event masks up to 1021 bytes in length. > With that patch the behaviour was almost compliant, but some issues were > still remaining, in particular regarding the handling of selective reads > and migration. > > This patchset fixes migration and the handling of selective reads, and > puts in place the support for 64-bit sclp event masks internally. > > A new property of the sclp-event device switches between the 32bit masks > and the compliant behaviour. The property is bound to the machine > version, so older machines keep the old broken behaviour, allowing for > migration, but the default is the compliant implementation. > > Fixes: 67915de9f0383ccf4a ("s390x/event-facility: variable-length event masks") > > Claudio Imbrenda (3): > s390x/sclp: proper support of larger send and receive masks > s390x/sclp: clean up sclp masks > s390x/sclp: extend SCLP event masks to 64 bits > > hw/char/sclpconsole-lm.c | 4 +- > hw/char/sclpconsole.c | 4 +- > hw/s390x/event-facility.c | 147 +++++++++++++++++++++++++++++++------- > hw/s390x/s390-virtio-ccw.c | 8 ++- > hw/s390x/sclpcpu.c | 4 +- > hw/s390x/sclpquiesce.c | 4 +- > include/hw/s390x/event-facility.h | 22 +++--- > 7 files changed, 149 insertions(+), 44 deletions(-) > I can't review the architecture details without documentation obviously, so another question: Do you have a test you can share? :)