From: "Emilio G. Cota" <cota@braap.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCHv2 1/2] translator: merge max_insns into DisasContextBase
Date: Wed, 21 Feb 2018 15:17:23 -0500 [thread overview]
Message-ID: <20180221201723.GA30501@flamenco> (raw)
In-Reply-To: <512f6e39-9aa0-7e4f-fad4-7085d499ae65@linaro.org>
On Wed, Feb 21, 2018 at 10:19:05 -0800, Richard Henderson wrote:
> On 02/19/2018 06:26 PM, Emilio G. Cota wrote:
> > @@ -68,6 +69,7 @@ typedef struct DisasContextBase {
> > target_ulong pc_next;
> > DisasJumpType is_jmp;
> > unsigned int num_insns;
> > + int max_insns;
> > bool singlestep_enabled;
> > } DisasContextBase;
>
> We really should pick the same type for max_insns and num_insns, which ever
> type we settle on. I can't see how we can go wrong with unsigned...
I was just trying to avoid warnings with -Wsign-compare in case
we ever enabled it.
Should I bother converting the "bound" variables we use for
MIN(max_insns, bound) to unsigned as well? Or just leave them
alone and forget about -Wsign-compare?
Thanks,
Emilio
next prev parent reply other threads:[~2018-02-21 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 2:26 [Qemu-devel] [PATCHv2 0/2] target/sh4: translator loop conversion Emilio G. Cota
2018-02-20 2:26 ` [Qemu-devel] [PATCHv2 1/2] translator: merge max_insns into DisasContextBase Emilio G. Cota
2018-02-21 18:19 ` Richard Henderson
2018-02-21 20:17 ` Emilio G. Cota [this message]
2018-02-21 20:23 ` Richard Henderson
2018-02-20 2:26 ` [Qemu-devel] [PATCHv2 2/2] target/sh4: convert to TranslatorOps Emilio G. Cota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221201723.GA30501@flamenco \
--to=cota@braap.org \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).