From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoZye-00007Q-FJ for qemu-devel@nongnu.org; Wed, 21 Feb 2018 14:22:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoZyY-0001L1-Uf for qemu-devel@nongnu.org; Wed, 21 Feb 2018 14:22:52 -0500 Date: Wed, 21 Feb 2018 20:22:24 +0100 From: Cornelia Huck Message-ID: <20180221202224.2d500f32.cohuck@redhat.com> In-Reply-To: <724303ad-100b-109f-f843-44e0795f0ae6@redhat.com> References: <20180221165628.78946-1-pasic@linux.vnet.ibm.com> <724303ad-100b-109f-f843-44e0795f0ae6@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/1] 390x/cpumodel: document S390FeatDef.bit not applicable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: Halil Pasic , Alexander Graf , Richard Henderson , Christian Borntraeger , qemu-devel@nongnu.org, qemu-s390x@nongnu.org On Wed, 21 Feb 2018 18:29:19 +0100 David Hildenbrand wrote: > On 21.02.2018 17:56, Halil Pasic wrote: s/390x/s390x/ > > The 'bit' field of the 'S390FeatDef' structure is not applicable to all > > its instances. Currently this field is not applicable, and remains > > unused, iff the feature is of type S390_FEAT_TYPE_MISC. Having the value 0 > > specified for multiple such feature definition was a little confusing, > > s/ / / also s/definition/definitions/ > > > as it's a perfectly legit bit value, and as the value of the bit > > field is usually ought to be unique for each feature of a given > > feature type. > > > > Let us introduce a specialized macro for defining features of type > > S390_FEAT_TYPE_MISC so, that one does not have to specify neither bit nor > > type (as the later is implied). > > s/later is implied/latter is implicit/ I kept 'implied'. > > > > > Signed-off-by: Halil Pasic > > --- > > > > v1 -> v2 > > * Specialized feature initializer macro for type MISC that does not > > require a bit value instead of defining a 'not a bit number' (that > > is extremal) bit number. > > --- > > target/s390x/cpu_features.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) (...) > Reviewed-by: David Hildenbrand Thanks, applied.