From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58625) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eooZv-0000i8-2q for qemu-devel@nongnu.org; Thu, 22 Feb 2018 05:58:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eooZt-0003HM-VN for qemu-devel@nongnu.org; Thu, 22 Feb 2018 05:58:19 -0500 Date: Thu, 22 Feb 2018 11:57:55 +0100 From: Kevin Wolf Message-ID: <20180222105755.GB4147@localhost.localdomain> References: <7b01ba4b-7f5f-30c7-d6d8-3c22f2774e7e@kamp.de> <7c23f28d-ee14-c504-ae13-04414c4b032e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7c23f28d-ee14-c504-ae13-04414c4b032e@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Lieven , qemu block , "qemu-devel@nongnu.org" , jsnow@redhat.com Am 20.02.2018 um 22:54 hat Paolo Bonzini geschrieben: > On 20/02/2018 18:04, Peter Lieven wrote: > > Hi, > > > > I remember we discussed a long time ago to limit the stack usage of all > > functions that are executed in a coroutine > > context to a very low value to be able to safely limit the coroutine > > stack size as well. > > IIRC the only issue was that hw/ide/atapi.c has mutual recursion between > ide_atapi_cmd_reply_end -> ide_transfer_start -> ahci_start_transfer -> > ide_atapi_cmd_reply_end. > > But perhaps it's not an issue, somebody needs to audit the code. I think John intended to get rid of the recursion sometime, but I doubt he has had the time so far. Kevin