From: Cornelia Huck <cohuck@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Alexander Graf <agraf@suse.de>,
Matthew Rosato <mjrosato@linux.vnet.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define
Date: Fri, 23 Feb 2018 11:11:18 +0100 [thread overview]
Message-ID: <20180223111118.1acc94be.cohuck@redhat.com> (raw)
In-Reply-To: <9caa0a62-e2cf-837b-a037-76cbcb851b0d@de.ibm.com>
On Fri, 23 Feb 2018 11:02:15 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> On 02/23/2018 10:54 AM, Cornelia Huck wrote:
> > It's already defined in cpu.h (to the same value) and not used in
> > the sclp code.
> >
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> > ---
> > include/hw/s390x/sclp.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
> > index 476cbf78f2..f9db243484 100644
> > --- a/include/hw/s390x/sclp.h
> > +++ b/include/hw/s390x/sclp.h
> > @@ -35,7 +35,6 @@
> > #define SCLP_FC_ASSIGN_ATTACH_READ_STOR 0xE00000000000ULL
> > #define SCLP_STARTING_SUBINCREMENT_ID 0x10001
> > #define SCLP_INCREMENT_UNIT 0x10000
> > -#define MAX_AVAIL_SLOTS 32
> > #define MAX_STORAGE_INCREMENTS 1020
> >
> > /* CPU hotplug SCLP codes */
> >
> Do we need this define and s390_get_memslot_count at all after removing
> the hotplug code?
>
Indeed. Let's kill it with fire :)
prev parent reply other threads:[~2018-02-23 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 9:54 [Qemu-devel] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define Cornelia Huck
2018-02-23 10:02 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2018-02-23 10:11 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223111118.1acc94be.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=mjrosato@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).