* [Qemu-devel] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define
@ 2018-02-23 9:54 Cornelia Huck
2018-02-23 10:02 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
0 siblings, 1 reply; 3+ messages in thread
From: Cornelia Huck @ 2018-02-23 9:54 UTC (permalink / raw)
To: Christian Borntraeger, Alexander Graf
Cc: Matthew Rosato, qemu-s390x, qemu-devel, Cornelia Huck
It's already defined in cpu.h (to the same value) and not used in
the sclp code.
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
include/hw/s390x/sclp.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
index 476cbf78f2..f9db243484 100644
--- a/include/hw/s390x/sclp.h
+++ b/include/hw/s390x/sclp.h
@@ -35,7 +35,6 @@
#define SCLP_FC_ASSIGN_ATTACH_READ_STOR 0xE00000000000ULL
#define SCLP_STARTING_SUBINCREMENT_ID 0x10001
#define SCLP_INCREMENT_UNIT 0x10000
-#define MAX_AVAIL_SLOTS 32
#define MAX_STORAGE_INCREMENTS 1020
/* CPU hotplug SCLP codes */
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define
2018-02-23 9:54 [Qemu-devel] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define Cornelia Huck
@ 2018-02-23 10:02 ` Christian Borntraeger
2018-02-23 10:11 ` Cornelia Huck
0 siblings, 1 reply; 3+ messages in thread
From: Christian Borntraeger @ 2018-02-23 10:02 UTC (permalink / raw)
To: Cornelia Huck, Alexander Graf; +Cc: Matthew Rosato, qemu-s390x, qemu-devel
On 02/23/2018 10:54 AM, Cornelia Huck wrote:
> It's already defined in cpu.h (to the same value) and not used in
> the sclp code.
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> include/hw/s390x/sclp.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
> index 476cbf78f2..f9db243484 100644
> --- a/include/hw/s390x/sclp.h
> +++ b/include/hw/s390x/sclp.h
> @@ -35,7 +35,6 @@
> #define SCLP_FC_ASSIGN_ATTACH_READ_STOR 0xE00000000000ULL
> #define SCLP_STARTING_SUBINCREMENT_ID 0x10001
> #define SCLP_INCREMENT_UNIT 0x10000
> -#define MAX_AVAIL_SLOTS 32
> #define MAX_STORAGE_INCREMENTS 1020
>
> /* CPU hotplug SCLP codes */
>
Do we need this define and s390_get_memslot_count at all after removing
the hotplug code?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [qemu-s390x] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define
2018-02-23 10:02 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
@ 2018-02-23 10:11 ` Cornelia Huck
0 siblings, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2018-02-23 10:11 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Alexander Graf, Matthew Rosato, qemu-s390x, qemu-devel
On Fri, 23 Feb 2018 11:02:15 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> On 02/23/2018 10:54 AM, Cornelia Huck wrote:
> > It's already defined in cpu.h (to the same value) and not used in
> > the sclp code.
> >
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> > ---
> > include/hw/s390x/sclp.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
> > index 476cbf78f2..f9db243484 100644
> > --- a/include/hw/s390x/sclp.h
> > +++ b/include/hw/s390x/sclp.h
> > @@ -35,7 +35,6 @@
> > #define SCLP_FC_ASSIGN_ATTACH_READ_STOR 0xE00000000000ULL
> > #define SCLP_STARTING_SUBINCREMENT_ID 0x10001
> > #define SCLP_INCREMENT_UNIT 0x10000
> > -#define MAX_AVAIL_SLOTS 32
> > #define MAX_STORAGE_INCREMENTS 1020
> >
> > /* CPU hotplug SCLP codes */
> >
> Do we need this define and s390_get_memslot_count at all after removing
> the hotplug code?
>
Indeed. Let's kill it with fire :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-23 10:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-23 9:54 [Qemu-devel] [PATCH] s390x/sclp: remove duplicate MAX_AVAIL_SLOTS define Cornelia Huck
2018-02-23 10:02 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2018-02-23 10:11 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).