From: Bandan Das <bsd@redhat.com>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com, eblake@redhat.com, peter.maydell@linaro.org,
berrange@redhat.com
Subject: [Qemu-devel] [PATCH v6 0/5] Initial write support for MTP objects
Date: Fri, 23 Feb 2018 11:48:24 -0500 [thread overview]
Message-ID: <20180223164829.29683-1-bsd@redhat.com> (raw)
v6:
4/5,5/5: Cleanup some checkpatch errors. Thank you, Patchew!
v5:
4/5,5/5: Add check for the RO bit and set response to STORE_READ_ONLY
v4:
4/5: Remove getumask and set default permissions to 0644
5/5: Remove usb_mtp_object_lookup_name out of #ifdef CONFIG_INOTIFY1
Test compilation on freebsd
v3:
3/5: Add a property that sets r/w to on/off (default:off)
Restructure ifdefs
4/5: Sort the response codes
5/5: Use actual names for fields in the dataset
Copy uint16_t to wchar_t and use wcstombs to get char type
for filename
v2:
3/5: Set mtp store flag to read only
4/5: Fix compiler warnings and change default file permissions
5/5: Fix file permissions
These patches implement write support for Qemu's MTP
emulation. Simple tests such as delete/move/edit/copy work ok.
Current issues/TODO:
- File transfers > 4GB has not been tested and will probably not work
- Some (or most) MTP clients don't advertise hidden files and folders (names
that start with a .) even though iiuc Qemu MTP does advertise these files.
This can confuse certain applications such as text editors or git.
- Also related, file editors typically run fsync when saving. Depending on
the MTP client, it may choose not to implement it (such as simple-mtpfs that
runs on top of fuse).
- Needs more testing :)
Bandan Das (5):
usb-mtp: Add one more argument when building results
usb-mtp: print parent path in IN_IGNORED trace fn
usb-mtp: Support delete of mtp objects
usb-mtp: Introduce write support for MTP objects
usb-mtp: Advertise SendObjectInfo for write support
hw/usb/dev-mtp.c | 471 +++++++++++++++++++++++++++++++++++++++++++++++++++----
1 file changed, 441 insertions(+), 30 deletions(-)
--
2.14.3
next reply other threads:[~2018-02-23 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 16:48 Bandan Das [this message]
2018-02-23 16:48 ` [Qemu-devel] [PATCH v6 1/5] usb-mtp: Add one more argument when building results Bandan Das
2018-02-23 16:48 ` [Qemu-devel] [PATCH v6 2/5] usb-mtp: print parent path in IN_IGNORED trace fn Bandan Das
2018-02-23 16:48 ` [Qemu-devel] [PATCH v6 3/5] usb-mtp: Support delete of mtp objects Bandan Das
2018-02-23 16:48 ` [Qemu-devel] [PATCH v6 4/5] usb-mtp: Introduce write support for MTP objects Bandan Das
2018-02-23 16:48 ` [Qemu-devel] [PATCH v6 5/5] usb-mtp: Advertise SendObjectInfo for write support Bandan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223164829.29683-1-bsd@redhat.com \
--to=bsd@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).