From: Fam Zheng <famz@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Eric Blake" <eblake@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] docker: dump 'config.log' if ./configure fails
Date: Sun, 25 Feb 2018 14:00:14 +0800 [thread overview]
Message-ID: <20180225060014.GA18756@lemon.usersys.redhat.com> (raw)
In-Reply-To: <20180215172306.10389-1-f4bug@amsat.org>
On Thu, 02/15 14:23, Philippe Mathieu-Daudé wrote:
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> tests/docker/common.rc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 7951555e3f..dd011cdf1e 100755
> --- a/tests/docker/common.rc
> +++ b/tests/docker/common.rc
> @@ -30,7 +30,9 @@ build_qemu()
> $@"
> echo "Configure options:"
> echo $config_opts
> - $QEMU_SRC/configure $config_opts && make $MAKEFLAGS
> + $QEMU_SRC/configure $config_opts || \
> + (cat config.log && prep_fail "Failed to run 'configure'")
> + make $MAKEFLAGS
If the configure failure is due to "this" patch, which it likely is, then
prep_fail is wrong. We want test_fail instead.
Fam
prev parent reply other threads:[~2018-02-25 6:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 17:23 [Qemu-devel] [PATCH] docker: dump 'config.log' if ./configure fails Philippe Mathieu-Daudé
2018-02-15 17:34 ` Daniel P. Berrangé
2018-02-15 17:41 ` Philippe Mathieu-Daudé
2018-02-15 18:26 ` Eric Blake
2018-02-15 18:41 ` Philippe Mathieu-Daudé
2018-02-25 6:00 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180225060014.GA18756@lemon.usersys.redhat.com \
--to=famz@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).