* [Qemu-devel] [PATCH] docker: dump 'config.log' if ./configure fails
@ 2018-02-15 17:23 Philippe Mathieu-Daudé
2018-02-15 17:34 ` Daniel P. Berrangé
2018-02-25 6:00 ` Fam Zheng
0 siblings, 2 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-02-15 17:23 UTC (permalink / raw)
To: Alex Bennée, Fam Zheng, Eric Blake
Cc: Philippe Mathieu-Daudé, qemu-devel
Suggested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
tests/docker/common.rc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/docker/common.rc b/tests/docker/common.rc
index 7951555e3f..dd011cdf1e 100755
--- a/tests/docker/common.rc
+++ b/tests/docker/common.rc
@@ -30,7 +30,9 @@ build_qemu()
$@"
echo "Configure options:"
echo $config_opts
- $QEMU_SRC/configure $config_opts && make $MAKEFLAGS
+ $QEMU_SRC/configure $config_opts || \
+ (cat config.log && prep_fail "Failed to run 'configure'")
+ make $MAKEFLAGS
}
test_fail()
--
2.16.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] docker: dump 'config.log' if ./configure fails
2018-02-15 17:23 [Qemu-devel] [PATCH] docker: dump 'config.log' if ./configure fails Philippe Mathieu-Daudé
@ 2018-02-15 17:34 ` Daniel P. Berrangé
2018-02-15 17:41 ` Philippe Mathieu-Daudé
2018-02-25 6:00 ` Fam Zheng
1 sibling, 1 reply; 6+ messages in thread
From: Daniel P. Berrangé @ 2018-02-15 17:34 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Alex Bennée, Fam Zheng, Eric Blake, qemu-devel
On Thu, Feb 15, 2018 at 02:23:06PM -0300, Philippe Mathieu-Daudé wrote:
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> tests/docker/common.rc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 7951555e3f..dd011cdf1e 100755
> --- a/tests/docker/common.rc
> +++ b/tests/docker/common.rc
> @@ -30,7 +30,9 @@ build_qemu()
> $@"
> echo "Configure options:"
> echo $config_opts
> - $QEMU_SRC/configure $config_opts && make $MAKEFLAGS
> + $QEMU_SRC/configure $config_opts || \
> + (cat config.log && prep_fail "Failed to run 'configure'")
> + make $MAKEFLAGS
> }
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Slightly nicer than my patch thanks to the prep_fail addition.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] docker: dump 'config.log' if ./configure fails
2018-02-15 17:34 ` Daniel P. Berrangé
@ 2018-02-15 17:41 ` Philippe Mathieu-Daudé
2018-02-15 18:26 ` Eric Blake
0 siblings, 1 reply; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-02-15 17:41 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: Fam Zheng, Alex Bennée, qemu-devel
On 02/15/2018 02:34 PM, Daniel P. Berrangé wrote:
> On Thu, Feb 15, 2018 at 02:23:06PM -0300, Philippe Mathieu-Daudé wrote:
>> Suggested-by: Eric Blake <eblake@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> tests/docker/common.rc | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
>> index 7951555e3f..dd011cdf1e 100755
>> --- a/tests/docker/common.rc
>> +++ b/tests/docker/common.rc
>> @@ -30,7 +30,9 @@ build_qemu()
>> $@"
>> echo "Configure options:"
>> echo $config_opts
>> - $QEMU_SRC/configure $config_opts && make $MAKEFLAGS
>> + $QEMU_SRC/configure $config_opts || \
>> + (cat config.log && prep_fail "Failed to run 'configure'")
>> + make $MAKEFLAGS
>> }
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> Slightly nicer than my patch thanks to the prep_fail addition.
Haha this was a funny experience of parallel programming :)
However your patch has a slightly nicer description!
>
>
> Regards,
> Daniel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] docker: dump 'config.log' if ./configure fails
2018-02-15 17:41 ` Philippe Mathieu-Daudé
@ 2018-02-15 18:26 ` Eric Blake
2018-02-15 18:41 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 6+ messages in thread
From: Eric Blake @ 2018-02-15 18:26 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Daniel P. Berrangé
Cc: Alex Bennée, Fam Zheng, qemu-devel
On 02/15/2018 11:41 AM, Philippe Mathieu-Daudé wrote:
> On 02/15/2018 02:34 PM, Daniel P. Berrangé wrote:
>> On Thu, Feb 15, 2018 at 02:23:06PM -0300, Philippe Mathieu-Daudé wrote:
>>> Suggested-by: Eric Blake <eblake@redhat.com>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> tests/docker/common.rc | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
>>> index 7951555e3f..dd011cdf1e 100755
>>> --- a/tests/docker/common.rc
>>> +++ b/tests/docker/common.rc
>>> @@ -30,7 +30,9 @@ build_qemu()
>>> $@"
>>> echo "Configure options:"
>>> echo $config_opts
>>> - $QEMU_SRC/configure $config_opts && make $MAKEFLAGS
>>> + $QEMU_SRC/configure $config_opts || \
>>> + (cat config.log && prep_fail "Failed to run 'configure'")
Is a subshell necessary; or can you get by with the simpler
{ cat && prep_fail "..."; }
>>> + make $MAKEFLAGS
>>> }
>>
>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>>
>> Slightly nicer than my patch thanks to the prep_fail addition.
>
> Haha this was a funny experience of parallel programming :)
>
> However your patch has a slightly nicer description!
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] docker: dump 'config.log' if ./configure fails
2018-02-15 18:26 ` Eric Blake
@ 2018-02-15 18:41 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-02-15 18:41 UTC (permalink / raw)
To: Eric Blake, Daniel P. Berrangé
Cc: Alex Bennée, Fam Zheng, qemu-devel
On 02/15/2018 03:26 PM, Eric Blake wrote:
> On 02/15/2018 11:41 AM, Philippe Mathieu-Daudé wrote:
>> On 02/15/2018 02:34 PM, Daniel P. Berrangé wrote:
>>> On Thu, Feb 15, 2018 at 02:23:06PM -0300, Philippe Mathieu-Daudé wrote:
>>>> Suggested-by: Eric Blake <eblake@redhat.com>
>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> ---
>>>> tests/docker/common.rc | 4 +++-
>>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
>>>> index 7951555e3f..dd011cdf1e 100755
>>>> --- a/tests/docker/common.rc
>>>> +++ b/tests/docker/common.rc
>>>> @@ -30,7 +30,9 @@ build_qemu()
>>>> $@"
>>>> echo "Configure options:"
>>>> echo $config_opts
>>>> - $QEMU_SRC/configure $config_opts && make $MAKEFLAGS
>>>> + $QEMU_SRC/configure $config_opts || \
>>>> + (cat config.log && prep_fail "Failed to run 'configure'")
>
> Is a subshell necessary; or can you get by with the simpler
> { cat && prep_fail "..."; }
You are right, since the subshell is not necessary, better to use { ;}
TIL :)
>
>>>> + make $MAKEFLAGS
>>>> }
>>>
>>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>>>
>>> Slightly nicer than my patch thanks to the prep_fail addition.
>>
>> Haha this was a funny experience of parallel programming :)
>>
>> However your patch has a slightly nicer description!
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] docker: dump 'config.log' if ./configure fails
2018-02-15 17:23 [Qemu-devel] [PATCH] docker: dump 'config.log' if ./configure fails Philippe Mathieu-Daudé
2018-02-15 17:34 ` Daniel P. Berrangé
@ 2018-02-25 6:00 ` Fam Zheng
1 sibling, 0 replies; 6+ messages in thread
From: Fam Zheng @ 2018-02-25 6:00 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: Alex Bennée, Eric Blake, qemu-devel
On Thu, 02/15 14:23, Philippe Mathieu-Daudé wrote:
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> tests/docker/common.rc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 7951555e3f..dd011cdf1e 100755
> --- a/tests/docker/common.rc
> +++ b/tests/docker/common.rc
> @@ -30,7 +30,9 @@ build_qemu()
> $@"
> echo "Configure options:"
> echo $config_opts
> - $QEMU_SRC/configure $config_opts && make $MAKEFLAGS
> + $QEMU_SRC/configure $config_opts || \
> + (cat config.log && prep_fail "Failed to run 'configure'")
> + make $MAKEFLAGS
If the configure failure is due to "this" patch, which it likely is, then
prep_fail is wrong. We want test_fail instead.
Fam
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-25 6:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-15 17:23 [Qemu-devel] [PATCH] docker: dump 'config.log' if ./configure fails Philippe Mathieu-Daudé
2018-02-15 17:34 ` Daniel P. Berrangé
2018-02-15 17:41 ` Philippe Mathieu-Daudé
2018-02-15 18:26 ` Eric Blake
2018-02-15 18:41 ` Philippe Mathieu-Daudé
2018-02-25 6:00 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).