From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, berto@igalia.com,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/4] qcow2: Document some maximum size constraints
Date: Tue, 27 Feb 2018 12:47:02 +0100 [thread overview]
Message-ID: <20180227114702.GA5269@localhost.localdomain> (raw)
In-Reply-To: <20180222155922.9833-3-eblake@redhat.com>
Am 22.02.2018 um 16:59 hat Eric Blake geschrieben:
> Although off_t permits up to 63 bits (8EB) of file offsets, in
> practice, we're going to hit other limits first. Document some
> of those limits in the qcow2 spec, and how choice of cluster size
> can influence some of the limits.
>
> While at it, notice that since we cannot map any virtual cluster
> to any address higher than 64 PB (56 bits) (due to the L1/L2 field
> encoding), it makes little sense to require the refcount table to
> access host offsets beyond that point. Mark the upper bits of
> the refcount table entries as reserved, with no ill effects, since
> it is unlikely that there are any existing images larger than 64PB
> in the first place, and thus all existing images already have those
> bits as 0.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
I think it would be good to mention the exact reason for the 56 bits in
the spec. Even this commit message is rather vague ('L1/L2 field
encoding'), so if at some point someone wonders, if we couldn't simply
extend the allowed range, they won't easily see that it's related to
compressed clusters.
Kevin
next prev parent reply other threads:[~2018-02-27 11:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 15:59 [Qemu-devel] [PATCH v3 0/4] qcow2: minor compression improvements Eric Blake
2018-02-22 15:59 ` [Qemu-devel] [PATCH v3 1/4] qcow2: Prefer byte-based calls into bs->file Eric Blake
2018-02-22 15:59 ` [Qemu-devel] [PATCH v3 2/4] qcow2: Document some maximum size constraints Eric Blake
2018-02-26 16:25 ` Alberto Garcia
2018-02-26 16:41 ` Eric Blake
2018-02-26 16:46 ` Alberto Garcia
2018-02-27 11:47 ` Kevin Wolf [this message]
2018-02-27 14:31 ` Eric Blake
2018-02-27 14:41 ` Alberto Garcia
2018-02-22 15:59 ` [Qemu-devel] [PATCH v3 3/4] qcow2: Don't allow overflow during cluster allocation Eric Blake
2018-02-26 16:29 ` Alberto Garcia
2018-02-22 15:59 ` [Qemu-devel] [PATCH v3 4/4] qcow2: Avoid memory over-allocation on compressed images Eric Blake
2018-02-22 16:23 ` Alberto Garcia
2018-02-22 19:02 ` Eric Blake
2018-02-26 16:35 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227114702.GA5269@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).