From: Cornelia Huck <cohuck@redhat.com>
To: peter.maydell@linaro.org
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
borntraeger@de.ibm.com, rth@twiddle.net, agraf@suse.de,
david@redhat.com, thuth@redhat.com,
Cornelia Huck <cohuck@redhat.com>
Subject: [Qemu-devel] [PULL 26/26] s390x: remove s390_get_memslot_count
Date: Tue, 27 Feb 2018 14:21:50 +0100 [thread overview]
Message-ID: <20180227132150.13847-27-cohuck@redhat.com> (raw)
In-Reply-To: <20180227132150.13847-1-cohuck@redhat.com>
Not needed anymore after removal of the memory hotplug code.
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
include/hw/s390x/sclp.h | 1 -
target/s390x/cpu.c | 9 ---------
target/s390x/cpu.h | 4 ----
target/s390x/kvm-stub.c | 5 -----
target/s390x/kvm.c | 5 -----
target/s390x/kvm_s390x.h | 1 -
6 files changed, 25 deletions(-)
diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
index 476cbf78f2..f9db243484 100644
--- a/include/hw/s390x/sclp.h
+++ b/include/hw/s390x/sclp.h
@@ -35,7 +35,6 @@
#define SCLP_FC_ASSIGN_ATTACH_READ_STOR 0xE00000000000ULL
#define SCLP_STARTING_SUBINCREMENT_ID 0x10001
#define SCLP_INCREMENT_UNIT 0x10000
-#define MAX_AVAIL_SLOTS 32
#define MAX_STORAGE_INCREMENTS 1020
/* CPU hotplug SCLP codes */
diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
index f02ed19c70..627002b225 100644
--- a/target/s390x/cpu.c
+++ b/target/s390x/cpu.c
@@ -437,15 +437,6 @@ void s390_cmma_reset(void)
}
}
-int s390_get_memslot_count(void)
-{
- if (kvm_enabled()) {
- return kvm_s390_get_memslot_count();
- } else {
- return MAX_AVAIL_SLOTS;
- }
-}
-
int s390_assign_subch_ioeventfd(EventNotifier *notifier, uint32_t sch_id,
int vq, bool assign)
{
diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
index 5bd6de7e8e..c5ef930876 100644
--- a/target/s390x/cpu.h
+++ b/target/s390x/cpu.h
@@ -621,9 +621,6 @@ QEMU_BUILD_BUG_ON(sizeof(SysIB) != 4096);
/* SIGP order code mask corresponding to bit positions 56-63 */
#define SIGP_ORDER_MASK 0x000000ff
-/* from s390-virtio-ccw */
-#define MAX_AVAIL_SLOTS 32
-
/* machine check interruption code */
/* subclasses */
@@ -695,7 +692,6 @@ int s390_get_clock(uint8_t *tod_high, uint64_t *tod_low);
int s390_set_clock(uint8_t *tod_high, uint64_t *tod_low);
void s390_crypto_reset(void);
bool s390_get_squash_mcss(void);
-int s390_get_memslot_count(void);
int s390_set_memory_limit(uint64_t new_limit, uint64_t *hw_limit);
void s390_cmma_reset(void);
void s390_enable_css_support(S390CPU *cpu);
diff --git a/target/s390x/kvm-stub.c b/target/s390x/kvm-stub.c
index 8cdcf83845..29b10542cc 100644
--- a/target/s390x/kvm-stub.c
+++ b/target/s390x/kvm-stub.c
@@ -84,11 +84,6 @@ void kvm_s390_cmma_reset(void)
{
}
-int kvm_s390_get_memslot_count(void)
-{
- return MAX_AVAIL_SLOTS;
-}
-
void kvm_s390_reset_vcpu(S390CPU *cpu)
{
}
diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
index 8ef509ece4..656aaea2cd 100644
--- a/target/s390x/kvm.c
+++ b/target/s390x/kvm.c
@@ -1854,11 +1854,6 @@ int kvm_s390_assign_subch_ioeventfd(EventNotifier *notifier, uint32_t sch,
return kvm_vm_ioctl(kvm_state, KVM_IOEVENTFD, &kick);
}
-int kvm_s390_get_memslot_count(void)
-{
- return kvm_check_extension(kvm_state, KVM_CAP_NR_MEMSLOTS);
-}
-
int kvm_s390_get_ri(void)
{
return cap_ri;
diff --git a/target/s390x/kvm_s390x.h b/target/s390x/kvm_s390x.h
index 7a3b862eea..c383bf4ee9 100644
--- a/target/s390x/kvm_s390x.h
+++ b/target/s390x/kvm_s390x.h
@@ -30,7 +30,6 @@ int kvm_s390_set_clock_ext(uint8_t *tod_high, uint64_t *tod_clock);
void kvm_s390_enable_css_support(S390CPU *cpu);
int kvm_s390_assign_subch_ioeventfd(EventNotifier *notifier, uint32_t sch,
int vq, bool assign);
-int kvm_s390_get_memslot_count(void);
int kvm_s390_cmma_active(void);
void kvm_s390_cmma_reset(void);
void kvm_s390_reset_vcpu(S390CPU *cpu);
--
2.13.6
next prev parent reply other threads:[~2018-02-27 13:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 13:21 [Qemu-devel] [PULL 00/26] s390x updates (and friends) Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 01/26] s390-ccw: refactor boot map table code Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 02/26] s390-ccw: refactor eckd_block_num to use CHS Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 03/26] s390-ccw: refactor IPL structs Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 04/26] s390-ccw: update libc Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 05/26] s390-ccw: move auxiliary IPL data to separate location Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 06/26] s390-ccw: parse and set boot menu options Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 07/26] s390-ccw: set up interactive boot menu parameters Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 08/26] s390-ccw: read stage2 boot loader data to find menu Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 09/26] s390-ccw: print zipl boot menu Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 10/26] s390-ccw: read user input for boot index via the SCLP console Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 11/26] s390-ccw: set cp_receive mask only when needed and consume pending service irqs Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 12/26] s390-ccw: use zipl values when no boot menu options are present Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 13/26] s390-ccw: interactive boot menu for scsi Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 14/26] pc-bios/s390: Rebuild the s390x firmware images with the boot menu changes Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 15/26] s390x/cpu: expose the guest crash information Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 16/26] s390/stattrib: Make SaveVMHandlers data static Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 17/26] s390x/tcg: fix disabling/enabling DAT Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 18/26] s390x/tcg: add various alignment checks Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 19/26] qmp: expose s390-specific CPU info Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 20/26] qmp: add query-cpus-fast Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 21/26] qmp: add architecture specific cpu data for query-cpus-fast Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 22/26] qemu-doc: deprecate query-cpus Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 23/26] hmp: change hmp_info_cpus to use query-cpus-fast Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 24/26] s390x/cpumodel: document S390FeatDef.bit not applicable Cornelia Huck
2018-02-27 13:21 ` [Qemu-devel] [PULL 25/26] s390x/sclp: remove memory hotplug support Cornelia Huck
2018-02-27 13:21 ` Cornelia Huck [this message]
2018-03-01 10:12 ` [Qemu-devel] [PULL 00/26] s390x updates (and friends) Peter Maydell
2018-03-01 10:27 ` Cornelia Huck
2018-03-01 11:17 ` Thomas Huth
2018-03-01 12:21 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227132150.13847-27-cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).