From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
peterx@redhat.com, "Markus Armbruster" <armbru@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: [Qemu-devel] [PATCH 00/14] qio: general non-default GMainContext support
Date: Wed, 28 Feb 2018 13:06:19 +0800 [thread overview]
Message-ID: <20180228050633.7410-1-peterx@redhat.com> (raw)
This is another preparation work for monitor OOB seires.
This series tries to allow QIO code to run with non-default
GMainContext. Note that for most places I kept the old code
untouched, and only modified/introduced new interfaces where there can
be a non-default GMainContext. The "where" is mostly migration and
chardev submodules, since these two parts of code can be run with
monitor IOThread in the future (which holds a non-default
GMainContext).
These are existing known issue to be solved with GSources that bound
to main thread:
- migration
- incoming side: still always running on main context, while we need
to be able to run some command in OOB thread [1]
- tcp chardev (non-tcp chardevs should all support non-NULL context now)
- server listening mode: QIO net listener used [2]
- TELNET session: an isolated GSource used (tcp_chr_telnet_init) [3]
- when "reconnect=N" is used, QIO threaded task is used [4]
- TLS session: QIO tls handshake is used (tcp_chr_tls_init) [5]
Patch 1-2 are cleanups and fixes.
Patch 3 introduced qio_channel_add_watch_full(), which is the core API
for QIO to support non-default context.
Patch 4 fixes the migration usage of QIO, which is problem [1] above.
Patch 5-7 fixes the net listeners to use non-default gcontext, which
solves problem [2] above.
Patch 8 fixes the TELNET GSource, which solves problem [3].
Patch 9-13 fixes the threaded QIOTask usage, which is for problem [4].
Patch 14 fixes the last TLS usage, which is problem [5].
The whole series survives with "make check". There are quite a few
QIO tests there. Let's see whether this can be acceptable before more
tests.
Please review. Thanks.
Peter Xu (14):
chardev: fix leak in tcp_chr_telnet_init_io()
qio: rename qio_task_thread_result
qio: introduce qio_channel_add_watch_full()
migration: let incoming side use thread context
qio: refactor net listener source operations
qio: store gsources for net listeners
qio/chardev: update net listener gcontext
chardev: allow telnet gsource to switch gcontext
qio: basic non-default context support for thread
qio: refcount QIOTask
qio/chardev: return QIOTask when connect async
qio: move QIOTaskThreadData into QIOTask
qio: allow threaded qiotask to switch contexts
qio/chardev: specify gcontext for TLS handshake
chardev/char-socket.c | 114 ++++++++++++++++++++++++++-------
include/io/channel-socket.h | 14 +++--
include/io/channel-tls.h | 22 ++++++-
include/io/channel.h | 31 ++++++++-
include/io/net-listener.h | 33 +++++++++-
include/io/task.h | 10 ++-
io/channel-socket.c | 21 ++++---
io/channel-tls.c | 91 ++++++++++++++++++++++-----
io/channel.c | 24 +++++--
io/dns-resolver.c | 3 +-
io/net-listener.c | 119 +++++++++++++++++++++--------------
io/task.c | 149 ++++++++++++++++++++++++++++++++++++--------
migration/exec.c | 11 ++--
migration/fd.c | 11 ++--
migration/socket.c | 12 ++--
tests/test-io-task.c | 2 +
16 files changed, 514 insertions(+), 153 deletions(-)
--
2.14.3
next reply other threads:[~2018-02-28 5:06 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 5:06 Peter Xu [this message]
2018-02-28 5:06 ` [Qemu-devel] [PATCH 01/14] chardev: fix leak in tcp_chr_telnet_init_io() Peter Xu
2018-02-28 9:26 ` Daniel P. Berrangé
2018-02-28 5:06 ` [Qemu-devel] [PATCH 02/14] qio: rename qio_task_thread_result Peter Xu
2018-02-28 9:26 ` Daniel P. Berrangé
2018-02-28 5:06 ` [Qemu-devel] [PATCH 03/14] qio: introduce qio_channel_add_watch_full() Peter Xu
2018-02-28 9:08 ` Daniel P. Berrangé
2018-02-28 12:44 ` Peter Xu
2018-02-28 12:47 ` Daniel P. Berrangé
2018-02-28 13:01 ` Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 04/14] migration: let incoming side use thread context Peter Xu
2018-02-28 9:10 ` Daniel P. Berrangé
2018-03-01 4:33 ` Peter Xu
2018-02-28 17:43 ` Dr. David Alan Gilbert
2018-03-01 2:53 ` Peter Xu
2018-03-01 9:58 ` Dr. David Alan Gilbert
2018-02-28 5:06 ` [Qemu-devel] [PATCH 05/14] qio: refactor net listener source operations Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 06/14] qio: store gsources for net listeners Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 07/14] qio/chardev: update net listener gcontext Peter Xu
2018-02-28 9:25 ` Daniel P. Berrangé
2018-02-28 12:52 ` Peter Xu
2018-02-28 13:06 ` Daniel P. Berrangé
2018-02-28 5:06 ` [Qemu-devel] [PATCH 08/14] chardev: allow telnet gsource to switch gcontext Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 09/14] qio: basic non-default context support for thread Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 10/14] qio: refcount QIOTask Peter Xu
2018-02-28 9:16 ` Daniel P. Berrangé
2018-02-28 12:54 ` Peter Xu
2018-02-28 13:07 ` Daniel P. Berrangé
2018-02-28 13:15 ` Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 11/14] qio/chardev: return QIOTask when connect async Peter Xu
2018-02-28 9:20 ` Daniel P. Berrangé
2018-02-28 13:07 ` Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 12/14] qio: move QIOTaskThreadData into QIOTask Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 13/14] qio: allow threaded qiotask to switch contexts Peter Xu
2018-02-28 9:23 ` Daniel P. Berrangé
2018-02-28 13:05 ` Peter Xu
2018-02-28 13:20 ` Daniel P. Berrangé
2018-03-01 8:49 ` Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 14/14] qio/chardev: specify gcontext for TLS handshake Peter Xu
2018-02-28 13:22 ` Daniel P. Berrangé
2018-03-01 6:28 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228050633.7410-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).