From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
peterx@redhat.com, "Markus Armbruster" <armbru@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: [Qemu-devel] [PATCH 10/14] qio: refcount QIOTask
Date: Wed, 28 Feb 2018 13:06:29 +0800 [thread overview]
Message-ID: <20180228050633.7410-11-peterx@redhat.com> (raw)
In-Reply-To: <20180228050633.7410-1-peterx@redhat.com>
It will be used in multiple threads in follow-up patches. Let it start
to have refcounts.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
include/io/task.h | 3 +++
io/task.c | 23 ++++++++++++++++++++++-
2 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/include/io/task.h b/include/io/task.h
index 9dbe3758d7..c6acd6489c 100644
--- a/include/io/task.h
+++ b/include/io/task.h
@@ -322,4 +322,7 @@ gpointer qio_task_get_result_pointer(QIOTask *task);
*/
Object *qio_task_get_source(QIOTask *task);
+void qio_task_ref(QIOTask *task);
+void qio_task_unref(QIOTask *task);
+
#endif /* QIO_TASK_H */
diff --git a/io/task.c b/io/task.c
index 204c0be286..00d3a5096a 100644
--- a/io/task.c
+++ b/io/task.c
@@ -32,6 +32,7 @@ struct QIOTask {
Error *err;
gpointer result;
GDestroyNotify destroyResult;
+ uint32_t refcount;
/* Threaded QIO task specific fields */
GSource *idle_source; /* The idle task to run complete routine */
@@ -57,6 +58,8 @@ QIOTask *qio_task_new(Object *source,
trace_qio_task_new(task, source, func, opaque);
+ qio_task_ref(task);
+
return task;
}
@@ -165,7 +168,7 @@ void qio_task_complete(QIOTask *task)
{
task->func(task, task->opaque);
trace_qio_task_complete(task);
- qio_task_free(task);
+ qio_task_unref(task);
}
@@ -208,3 +211,21 @@ Object *qio_task_get_source(QIOTask *task)
{
return task->source;
}
+
+void qio_task_ref(QIOTask *task)
+{
+ if (!task) {
+ return;
+ }
+ atomic_inc(&task->refcount);
+}
+
+void qio_task_unref(QIOTask *task)
+{
+ if (!task) {
+ return;
+ }
+ if (atomic_fetch_dec(&task->refcount) == 1) {
+ qio_task_free(task);
+ }
+}
--
2.14.3
next prev parent reply other threads:[~2018-02-28 5:07 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 5:06 [Qemu-devel] [PATCH 00/14] qio: general non-default GMainContext support Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 01/14] chardev: fix leak in tcp_chr_telnet_init_io() Peter Xu
2018-02-28 9:26 ` Daniel P. Berrangé
2018-02-28 5:06 ` [Qemu-devel] [PATCH 02/14] qio: rename qio_task_thread_result Peter Xu
2018-02-28 9:26 ` Daniel P. Berrangé
2018-02-28 5:06 ` [Qemu-devel] [PATCH 03/14] qio: introduce qio_channel_add_watch_full() Peter Xu
2018-02-28 9:08 ` Daniel P. Berrangé
2018-02-28 12:44 ` Peter Xu
2018-02-28 12:47 ` Daniel P. Berrangé
2018-02-28 13:01 ` Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 04/14] migration: let incoming side use thread context Peter Xu
2018-02-28 9:10 ` Daniel P. Berrangé
2018-03-01 4:33 ` Peter Xu
2018-02-28 17:43 ` Dr. David Alan Gilbert
2018-03-01 2:53 ` Peter Xu
2018-03-01 9:58 ` Dr. David Alan Gilbert
2018-02-28 5:06 ` [Qemu-devel] [PATCH 05/14] qio: refactor net listener source operations Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 06/14] qio: store gsources for net listeners Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 07/14] qio/chardev: update net listener gcontext Peter Xu
2018-02-28 9:25 ` Daniel P. Berrangé
2018-02-28 12:52 ` Peter Xu
2018-02-28 13:06 ` Daniel P. Berrangé
2018-02-28 5:06 ` [Qemu-devel] [PATCH 08/14] chardev: allow telnet gsource to switch gcontext Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 09/14] qio: basic non-default context support for thread Peter Xu
2018-02-28 5:06 ` Peter Xu [this message]
2018-02-28 9:16 ` [Qemu-devel] [PATCH 10/14] qio: refcount QIOTask Daniel P. Berrangé
2018-02-28 12:54 ` Peter Xu
2018-02-28 13:07 ` Daniel P. Berrangé
2018-02-28 13:15 ` Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 11/14] qio/chardev: return QIOTask when connect async Peter Xu
2018-02-28 9:20 ` Daniel P. Berrangé
2018-02-28 13:07 ` Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 12/14] qio: move QIOTaskThreadData into QIOTask Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 13/14] qio: allow threaded qiotask to switch contexts Peter Xu
2018-02-28 9:23 ` Daniel P. Berrangé
2018-02-28 13:05 ` Peter Xu
2018-02-28 13:20 ` Daniel P. Berrangé
2018-03-01 8:49 ` Peter Xu
2018-02-28 5:06 ` [Qemu-devel] [PATCH 14/14] qio/chardev: specify gcontext for TLS handshake Peter Xu
2018-02-28 13:22 ` Daniel P. Berrangé
2018-03-01 6:28 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228050633.7410-11-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).