From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqxrW-0003wu-3j for qemu-devel@nongnu.org; Wed, 28 Feb 2018 04:17:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqxrS-0001HS-3n for qemu-devel@nongnu.org; Wed, 28 Feb 2018 04:17:22 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:48102 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqxrR-0001Fu-TV for qemu-devel@nongnu.org; Wed, 28 Feb 2018 04:17:18 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C6B5E7D845 for ; Wed, 28 Feb 2018 09:17:07 +0000 (UTC) Date: Wed, 28 Feb 2018 09:16:59 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180228091659.GD31550@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180228050633.7410-1-peterx@redhat.com> <20180228050633.7410-11-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180228050633.7410-11-peterx@redhat.com> Subject: Re: [Qemu-devel] [PATCH 10/14] qio: refcount QIOTask List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Paolo Bonzini , Juan Quintela , Markus Armbruster , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Stefan Hajnoczi , "Dr . David Alan Gilbert" On Wed, Feb 28, 2018 at 01:06:29PM +0800, Peter Xu wrote: > It will be used in multiple threads in follow-up patches. Let it start > to have refcounts. > > Signed-off-by: Peter Xu > --- > include/io/task.h | 3 +++ > io/task.c | 23 ++++++++++++++++++++++- > 2 files changed, 25 insertions(+), 1 deletion(-) > > diff --git a/include/io/task.h b/include/io/task.h > index 9dbe3758d7..c6acd6489c 100644 > --- a/include/io/task.h > +++ b/include/io/task.h > @@ -322,4 +322,7 @@ gpointer qio_task_get_result_pointer(QIOTask *task); > */ > Object *qio_task_get_source(QIOTask *task); > > +void qio_task_ref(QIOTask *task); > +void qio_task_unref(QIOTask *task); It should just be turned back into a QObject as it was originally, so we get refcounting for free. > diff --git a/io/task.c b/io/task.c > index 204c0be286..00d3a5096a 100644 > --- a/io/task.c > +++ b/io/task.c > @@ -32,6 +32,7 @@ struct QIOTask { > Error *err; > gpointer result; > GDestroyNotify destroyResult; > + uint32_t refcount; > > /* Threaded QIO task specific fields */ > GSource *idle_source; /* The idle task to run complete routine */ > @@ -57,6 +58,8 @@ QIOTask *qio_task_new(Object *source, > > trace_qio_task_new(task, source, func, opaque); > > + qio_task_ref(task); > + > return task; > } > > @@ -165,7 +168,7 @@ void qio_task_complete(QIOTask *task) > { > task->func(task, task->opaque); > trace_qio_task_complete(task); > - qio_task_free(task); > + qio_task_unref(task); > } > > > @@ -208,3 +211,21 @@ Object *qio_task_get_source(QIOTask *task) > { > return task->source; > } > + > +void qio_task_ref(QIOTask *task) > +{ > + if (!task) { > + return; > + } > + atomic_inc(&task->refcount); > +} > + > +void qio_task_unref(QIOTask *task) > +{ > + if (!task) { > + return; > + } > + if (atomic_fetch_dec(&task->refcount) == 1) { > + qio_task_free(task); > + } > +} > -- > 2.14.3 > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|