From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1er1Sk-00069O-Sr for qemu-devel@nongnu.org; Wed, 28 Feb 2018 08:08:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1er1Sj-0000Hp-Rm for qemu-devel@nongnu.org; Wed, 28 Feb 2018 08:08:02 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35768 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1er1Sj-0000HA-Mi for qemu-devel@nongnu.org; Wed, 28 Feb 2018 08:08:01 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7EA924075166 for ; Wed, 28 Feb 2018 13:07:57 +0000 (UTC) Date: Wed, 28 Feb 2018 13:07:44 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180228130744.GI17774@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180228050633.7410-1-peterx@redhat.com> <20180228050633.7410-11-peterx@redhat.com> <20180228091659.GD31550@redhat.com> <20180228125400.GI27381@xz-mi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180228125400.GI27381@xz-mi> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 10/14] qio: refcount QIOTask List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Paolo Bonzini , Juan Quintela , Markus Armbruster , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Stefan Hajnoczi , "Dr . David Alan Gilbert" On Wed, Feb 28, 2018 at 08:54:00PM +0800, Peter Xu wrote: > On Wed, Feb 28, 2018 at 09:16:59AM +0000, Daniel P. Berrang=C3=A9 wrote= : > > On Wed, Feb 28, 2018 at 01:06:29PM +0800, Peter Xu wrote: > > > It will be used in multiple threads in follow-up patches. Let it s= tart > > > to have refcounts. > > >=20 > > > Signed-off-by: Peter Xu > > > --- > > > include/io/task.h | 3 +++ > > > io/task.c | 23 ++++++++++++++++++++++- > > > 2 files changed, 25 insertions(+), 1 deletion(-) > > >=20 > > > diff --git a/include/io/task.h b/include/io/task.h > > > index 9dbe3758d7..c6acd6489c 100644 > > > --- a/include/io/task.h > > > +++ b/include/io/task.h > > > @@ -322,4 +322,7 @@ gpointer qio_task_get_result_pointer(QIOTask *t= ask); > > > */ > > > Object *qio_task_get_source(QIOTask *task); > > > =20 > > > +void qio_task_ref(QIOTask *task); > > > +void qio_task_unref(QIOTask *task); > >=20 > > It should just be turned back into a QObject as it was originally, > > so we get refcounting for free. >=20 > Could you point me the commit that has the original code? I would be > glad to revert to that, or yeah I can switch to QObject too. Thanks, It was never actually committed - it was just that way during initial review but was suggested to be simplified as ref counting wasn't needed. That all said, having now seen the later parts of this patch series, I don't think we would need todo this at all, because we should not be exposing the GTask to callers and thus the refcounting question goes away Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|