From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH v2 07/13] console: add ui module loading support
Date: Thu, 1 Mar 2018 11:05:41 +0100 [thread overview]
Message-ID: <20180301100547.18962-8-kraxel@redhat.com> (raw)
In-Reply-To: <20180301100547.18962-1-kraxel@redhat.com>
If a requested user interface is not available, try loading it as
module, simliar to block layer modules. Needed to keep things working
when followup patches start to build user interfaces as modules.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
Makefile.objs | 1 +
include/qemu/module.h | 1 +
ui/console.c | 6 ++++++
3 files changed, 8 insertions(+)
diff --git a/Makefile.objs b/Makefile.objs
index 5dc134818c..57ca6d908b 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -56,6 +56,7 @@ common-obj-y += hw/
common-obj-y += replay/
common-obj-y += ui/
+common-obj-m += ui/
common-obj-y += bt-host.o bt-vhci.o
bt-host.o-cflags := $(BLUEZ_CFLAGS)
diff --git a/include/qemu/module.h b/include/qemu/module.h
index 56dd218205..9fea75aaeb 100644
--- a/include/qemu/module.h
+++ b/include/qemu/module.h
@@ -53,6 +53,7 @@ typedef enum {
#define trace_init(function) module_init(function, MODULE_INIT_TRACE)
#define block_module_load_one(lib) module_load_one("block-", lib)
+#define ui_module_load_one(lib) module_load_one("ui-", lib)
void register_module_init(void (*fn)(void), module_init_type type);
void register_dso_module_init(void (*fn)(void), module_init_type type);
diff --git a/ui/console.c b/ui/console.c
index 25d342cdcb..78efab269a 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -2199,6 +2199,9 @@ bool qemu_display_find_default(DisplayOptions *opts)
for (i = 0; i < ARRAY_SIZE(prio); i++) {
if (dpys[prio[i]] == NULL) {
+ ui_module_load_one(DisplayType_lookup.array[prio[i]]);
+ }
+ if (dpys[prio[i]] == NULL) {
continue;
}
opts->type = prio[i];
@@ -2214,6 +2217,9 @@ void qemu_display_early_init(DisplayOptions *opts)
return;
}
if (dpys[opts->type] == NULL) {
+ ui_module_load_one(DisplayType_lookup.array[opts->type]);
+ }
+ if (dpys[opts->type] == NULL) {
error_report("Display '%s' is not available.",
DisplayType_lookup.array[opts->type]);
exit(1);
--
2.9.3
next prev parent reply other threads:[~2018-03-01 10:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 10:05 [Qemu-devel] [PATCH v2 00/13] ui: build sdl, gtk and curses as modules Gerd Hoffmann
2018-03-01 10:05 ` [Qemu-devel] [PATCH v2 01/13] console: add qemu display registry, add gtk Gerd Hoffmann
2018-03-01 10:05 ` [Qemu-devel] [PATCH v2 02/13] sdl: switch over to new display registry Gerd Hoffmann
2018-03-01 10:05 ` [Qemu-devel] [PATCH v2 03/13] cocoa: " Gerd Hoffmann
2018-03-01 10:05 ` [Qemu-devel] [PATCH v2 04/13] curses: " Gerd Hoffmann
2018-03-01 10:05 ` [Qemu-devel] [PATCH v2 05/13] egl-headless: " Gerd Hoffmann
2018-03-01 10:05 ` [Qemu-devel] [PATCH v2 06/13] console: add and use qemu_display_find_default Gerd Hoffmann
2018-03-01 10:05 ` Gerd Hoffmann [this message]
2018-03-01 10:05 ` [Qemu-devel] [PATCH v2 08/13] configure: add X11 vars to config-host.mak Gerd Hoffmann
2018-03-01 10:05 ` [Qemu-devel] [PATCH v2 09/13] configure: opengl doesn't depend on x11 Gerd Hoffmann
2018-03-01 10:05 ` [Qemu-devel] [PATCH v2 10/13] ui/gtk: build as module Gerd Hoffmann
2018-03-01 10:05 ` [Qemu-devel] [PATCH v2 11/13] ui/curses: " Gerd Hoffmann
2018-03-01 10:05 ` [Qemu-devel] [PATCH v2 12/13] audio: rename CONFIG_* to CONFIG_AUDIO_* Gerd Hoffmann
2018-03-01 10:05 ` [Qemu-devel] [PATCH v2 13/13] ui/sdl: build as module Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301100547.18962-8-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).