From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erQ8i-00050V-VG for qemu-devel@nongnu.org; Thu, 01 Mar 2018 10:29:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erQ8f-000241-1M for qemu-devel@nongnu.org; Thu, 01 Mar 2018 10:29:00 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:47330 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1erQ8e-00023p-RX for qemu-devel@nongnu.org; Thu, 01 Mar 2018 10:28:56 -0500 Date: Thu, 1 Mar 2018 15:28:51 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20180301152850.GH2994@work-vm> References: <20180228180215.25470-1-wei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180228180215.25470-1-wei@redhat.com> Subject: Re: [Qemu-devel] [PATCH V7 0/4] tests: Add migration test for aarch64 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Huang Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, quintela@redhat.com, drjones@redhat.com * Wei Huang (wei@redhat.com) wrote: > This patchset adds a migration test for aarch64. It leverages > Dave Gilbert's recent patch "tests/migration: Add source to PC boot block" > to create a new test case for aarch64. Other than Drew's comment about the ppc comment; I'm happy with this. Dave > V6->V7: > * Define test memory start/end addresses for all architectures > * Check aarch64 kernel binary size, limit under 512KB > > V5->V6: > * Add Reviewed-by to patch 1-3 > * Add more design notes in patch 4 (aarch64 assembly compilation, bin space) > > V4->V5: > * Extract cross compilation detection code into rules.mak for sharing > * Minor comment and code revision in migration-test.c & aarch64-a-b-kernel.S > > V3->V4: > * Rename .s to .S, allowing assembly to include C-style header file > * Move test defines into a new migration-test.h file > * Use different cpu & gic settings for kvm and tcg modes on aarch64 > * Clean up aarch64-a-b-kernel.S based on Andrew Jones' comments > > V2->V3: > * Convert build script to Makefile > * Add cross-compilation support > * Fix CPU type for "tcg" machine type > * Revise asm code and the compilation process from asm to header file > > V1->V2: > * Similar to Dave Gilbert's recent changes to migration-test, we > provide the test source and a build script in V2. > * aarch64 kernel blob is defined as "unsigned char" because the source > is now provided in V2. > * Add "-machine none" to test_deprecated() because aarch64 doesn't have > a default machine type. > > RFC->V1: > * aarch64 kernel blob is defined as an uint32_t array > * The test code is re-written to address a data caching issue under KVM. > Tests passed under both x86 and aarch64. > * Re-use init_bootfile_x86() for both x86 and aarch64 > * Other minor fixes > > Thanks, > -Wei > > Wei Huang (4): > rules: Move cross compilation auto detection functions to rules.mak > tests/migration: Convert the boot block compilation script into > Makefile > tests/migration: Add migration-test header file > tests: Add migration test for aarch64 > > roms/Makefile | 24 ++----- > rules.mak | 15 +++++ > tests/Makefile.include | 1 + > tests/migration-test.c | 78 +++++++++++++++++----- > tests/migration/Makefile | 44 ++++++++++++ > tests/migration/aarch64-a-b-kernel.S | 75 +++++++++++++++++++++ > tests/migration/aarch64-a-b-kernel.h | 19 ++++++ > tests/migration/migration-test.h | 31 +++++++++ > tests/migration/rebuild-x86-bootblock.sh | 33 --------- > .../{x86-a-b-bootblock.s => x86-a-b-bootblock.S} | 12 ++-- > tests/migration/x86-a-b-bootblock.h | 4 +- > 11 files changed, 260 insertions(+), 76 deletions(-) > create mode 100644 tests/migration/Makefile > create mode 100644 tests/migration/aarch64-a-b-kernel.S > create mode 100644 tests/migration/aarch64-a-b-kernel.h > create mode 100644 tests/migration/migration-test.h > delete mode 100755 tests/migration/rebuild-x86-bootblock.sh > rename tests/migration/{x86-a-b-bootblock.s => x86-a-b-bootblock.S} (88%) > > -- > 2.14.3 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK