From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erU6x-0000wT-5f for qemu-devel@nongnu.org; Thu, 01 Mar 2018 14:43:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erU6v-0007iz-Lv for qemu-devel@nongnu.org; Thu, 01 Mar 2018 14:43:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44456) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1erU6v-0007i5-Bh for qemu-devel@nongnu.org; Thu, 01 Mar 2018 14:43:25 -0500 From: Eric Blake Date: Thu, 1 Mar 2018 13:42:33 -0600 Message-Id: <20180301194245.29854-19-eblake@redhat.com> In-Reply-To: <20180301194245.29854-1-eblake@redhat.com> References: <20180301194245.29854-1-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 18/30] qapi: Rename generated qmp-marshal.c to qmp-commands.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Markus Armbruster , Michael Roth From: Markus Armbruster All generated .c are named like their .h, except for qmp-marshal.c and qmp-commands.h. To add to the confusion, tests-qmp-commands.c falsely matches generated test-qmp-commands.h. Get rid of this unnecessary complication. Signed-off-by: Markus Armbruster Message-Id: <20180211093607.27351-19-armbru@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Michael Roth Signed-off-by: Eric Blake --- docs/devel/qapi-code-gen.txt | 6 +++--- Makefile | 6 +++--- Makefile.objs | 2 +- scripts/qapi/commands.py | 2 +- tests/{test-qmp-commands.c =3D> test-qmp-cmds.c} | 0 .gitignore | 3 +-- qga/Makefile.objs | 2 +- tests/.gitignore | 5 ++--- tests/Makefile.include | 10 +++++----- 9 files changed, 17 insertions(+), 19 deletions(-) rename tests/{test-qmp-commands.c =3D> test-qmp-cmds.c} (100%) diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt index a525ef369f4..c86792add2e 100644 --- a/docs/devel/qapi-code-gen.txt +++ b/docs/devel/qapi-code-gen.txt @@ -1147,8 +1147,8 @@ declares qmp_COMMAND() that the user must implement= . The following files are generated: -$(prefix)qmp-marshal.c: Command marshal/dispatch functions for each - QMP command defined in the schema +$(prefix)qmp-commands.c: Command marshal/dispatch functions for each + QMP command defined in the schema $(prefix)qmp-commands.h: Function prototypes for the QMP commands specified in the schema @@ -1170,7 +1170,7 @@ Example: void qmp_marshal_my_command(QDict *args, QObject **ret, Error **errp= ); #endif - $ cat qapi-generated/example-qmp-marshal.c + $ cat qapi-generated/example-qmp-commands.c [Uninteresting stuff omitted...] static void qmp_marshal_output_UserDefOne(UserDefOne *ret_in, QObjec= t **ret_out, Error **errp) diff --git a/Makefile b/Makefile index 53c7dc5d19e..b9f320f6ba7 100644 --- a/Makefile +++ b/Makefile @@ -91,7 +91,7 @@ include $(SRC_PATH)/rules.mak GENERATED_FILES =3D qemu-version.h config-host.h qemu-options.def GENERATED_FILES +=3D qmp-commands.h qapi-types.h qapi-visit.h qapi-event= .h -GENERATED_FILES +=3D qmp-marshal.c qapi-types.c qapi-visit.c qapi-event.= c +GENERATED_FILES +=3D qmp-commands.c qapi-types.c qapi-visit.c qapi-event= .c GENERATED_FILES +=3D qmp-introspect.h GENERATED_FILES +=3D qmp-introspect.c GENERATED_FILES +=3D qapi-doc.texi @@ -495,7 +495,7 @@ $(SRC_PATH)/scripts/qapi-gen.py qga/qapi-generated/qga-qapi-types.c qga/qapi-generated/qga-qapi-types.h = \ qga/qapi-generated/qga-qapi-visit.c qga/qapi-generated/qga-qapi-visit.h = \ -qga/qapi-generated/qga-qmp-commands.h qga/qapi-generated/qga-qmp-marshal= .c \ +qga/qapi-generated/qga-qmp-commands.h qga/qapi-generated/qga-qmp-command= s.c \ qga/qapi-generated/qga-qapi-doc.texi: \ qga/qapi-generated/qapi-gen-timestamp ; qga/qapi-generated/qapi-gen-timestamp: $(SRC_PATH)/qga/qapi-schema.json = $(qapi-py) @@ -521,7 +521,7 @@ qapi-modules =3D $(SRC_PATH)/qapi-schema.json $(SRC_P= ATH)/qapi/common.json \ qapi-types.c qapi-types.h \ qapi-visit.c qapi-visit.h \ -qmp-commands.h qmp-marshal.c \ +qmp-commands.h qmp-commands.c \ qapi-event.c qapi-event.h \ qmp-introspect.h qmp-introspect.c \ qapi-doc.texi: \ diff --git a/Makefile.objs b/Makefile.objs index 5dc134818c9..7aa67d89f8e 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -78,7 +78,7 @@ common-obj-$(CONFIG_FDT) +=3D device_tree.o ###################################################################### # qapi -common-obj-y +=3D qmp-marshal.o +common-obj-y +=3D qmp-commands.o common-obj-y +=3D qmp-introspect.o common-obj-y +=3D qmp.o hmp.o endif diff --git a/scripts/qapi/commands.py b/scripts/qapi/commands.py index a744611d580..05fe33a03bc 100644 --- a/scripts/qapi/commands.py +++ b/scripts/qapi/commands.py @@ -289,5 +289,5 @@ void %(c_prefix)sqmp_init_marshal(QmpCommandList *cmd= s); schema.visit(vis) genc.add(vis.defn) genh.add(vis.decl) - genc.write(output_dir, prefix + 'qmp-marshal.c') + genc.write(output_dir, prefix + 'qmp-commands.c') genh.write(output_dir, prefix + 'qmp-commands.h') diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-cmds.c similarity index 100% rename from tests/test-qmp-commands.c rename to tests/test-qmp-cmds.c diff --git a/.gitignore b/.gitignore index 2f9a92f6cc9..7d783e6e66b 100644 --- a/.gitignore +++ b/.gitignore @@ -33,9 +33,8 @@ /qapi-visit.[ch] /qapi-event.[ch] /qapi-doc.texi -/qmp-commands.h +/qmp-commands.[ch] /qmp-introspect.[ch] -/qmp-marshal.c /qemu-doc.html /qemu-doc.info /qemu-doc.txt diff --git a/qga/Makefile.objs b/qga/Makefile.objs index 1c5986c0bb5..6151378ae42 100644 --- a/qga/Makefile.objs +++ b/qga/Makefile.objs @@ -3,6 +3,6 @@ qga-obj-$(CONFIG_POSIX) +=3D commands-posix.o channel-pos= ix.o qga-obj-$(CONFIG_WIN32) +=3D commands-win32.o channel-win32.o service-wi= n32.o qga-obj-$(CONFIG_WIN32) +=3D vss-win32.o qga-obj-y +=3D qapi-generated/qga-qapi-types.o qapi-generated/qga-qapi-v= isit.o -qga-obj-y +=3D qapi-generated/qga-qmp-marshal.o +qga-obj-y +=3D qapi-generated/qga-qmp-commands.o qga-vss-dll-obj-$(CONFIG_QGA_VSS) +=3D vss-win32/ diff --git a/tests/.gitignore b/tests/.gitignore index e5c744b7ed6..2629cfc2f98 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -70,13 +70,12 @@ test-qdist test-qga test-qht test-qht-par -test-qmp-commands -test-qmp-commands.h +test-qmp-cmds +test-qmp-commands.[ch] test-qmp-event test-qobject-input-strict test-qobject-input-visitor test-qmp-introspect.[ch] -test-qmp-marshal.c test-qobject-output-visitor test-rcu-list test-replication diff --git a/tests/Makefile.include b/tests/Makefile.include index 5b0de376854..2de46f8acb7 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -61,8 +61,8 @@ check-unit-y +=3D tests/test-clone-visitor$(EXESUF) gcov-files-test-clone-visitor-y =3D qapi/qapi-clone-visitor.c check-unit-y +=3D tests/test-qobject-input-visitor$(EXESUF) gcov-files-test-qobject-input-visitor-y =3D qapi/qobject-input-visitor.c -check-unit-y +=3D tests/test-qmp-commands$(EXESUF) -gcov-files-test-qmp-commands-y =3D qapi/qmp-dispatch.c +check-unit-y +=3D tests/test-qmp-cmds$(EXESUF) +gcov-files-test-qmp-cmds-y =3D qapi/qmp-dispatch.c check-unit-y +=3D tests/test-string-input-visitor$(EXESUF) gcov-files-test-string-input-visitor-y =3D qapi/string-input-visitor.c check-unit-y +=3D tests/test-string-output-visitor$(EXESUF) @@ -580,7 +580,7 @@ test-obj-y =3D tests/check-qnum.o tests/check-qstring= .o tests/check-qdict.o \ tests/test-string-input-visitor.o tests/test-qobject-output-visitor.o \ tests/test-clone-visitor.o \ tests/test-qobject-input-visitor.o \ - tests/test-qmp-commands.o tests/test-visitor-serialization.o \ + tests/test-qmp-cmds.o tests/test-visitor-serialization.o \ tests/test-x86-cpuid.o tests/test-mul64.o tests/test-int128.o \ tests/test-opts-visitor.o tests/test-qmp-event.o \ tests/rcutorture.o tests/test-rcu-list.o \ @@ -660,7 +660,7 @@ tests/test-replication$(EXESUF): tests/test-replicati= on.o $(test-util-obj-y) \ tests/test-qapi-types.c tests/test-qapi-types.h \ tests/test-qapi-visit.c tests/test-qapi-visit.h \ -tests/test-qmp-commands.h tests/test-qmp-marshal.c \ +tests/test-qmp-commands.h tests/test-qmp-commands.c \ tests/test-qapi-event.c tests/test-qapi-event.h \ tests/test-qmp-introspect.c tests/test-qmp-introspect.h: \ tests/test-qapi-gen-timestamp ; @@ -683,7 +683,7 @@ tests/test-qmp-event$(EXESUF): tests/test-qmp-event.o= $(test-qapi-obj-y) tests/test-qobject-output-visitor$(EXESUF): tests/test-qobject-output-vi= sitor.o $(test-qapi-obj-y) tests/test-clone-visitor$(EXESUF): tests/test-clone-visitor.o $(test-qap= i-obj-y) tests/test-qobject-input-visitor$(EXESUF): tests/test-qobject-input-visi= tor.o $(test-qapi-obj-y) -tests/test-qmp-commands$(EXESUF): tests/test-qmp-commands.o tests/test-q= mp-marshal.o $(test-qapi-obj-y) +tests/test-qmp-cmds$(EXESUF): tests/test-qmp-cmds.o tests/test-qmp-comma= nds.o $(test-qapi-obj-y) tests/test-visitor-serialization$(EXESUF): tests/test-visitor-serializat= ion.o $(test-qapi-obj-y) tests/test-opts-visitor$(EXESUF): tests/test-opts-visitor.o $(test-qapi-= obj-y) --=20 2.14.3