From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, groug@kaod.org,
surajjs@au1.ibm.com, mark.cave-ayland@ilande.co.uk,
Suraj Jitindar Singh <sjitindarsingh@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 18/24] target/ppc: Check mask when setting cap_ppc_safe_indirect_branch
Date: Fri, 2 Mar 2018 17:03:44 +1100 [thread overview]
Message-ID: <20180302060350.24330-19-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20180302060350.24330-1-david@gibson.dropbear.id.au>
From: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Check the character and character_mask field when setting
cap_ppc_safe_indirect_branch based on the hypervisor response
to KVM_PPC_GET_CPU_CHAR. Previously the mask field wasn't checked
which was incorrect.
Fixes: 8acc2ae5 (target/ppc/kvm: Add cap_ppc_safe_[cache/bounds_check/indirect_branch])
Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
target/ppc/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
index 9842b3bb12..2c183f61e2 100644
--- a/target/ppc/kvm.c
+++ b/target/ppc/kvm.c
@@ -2494,7 +2494,7 @@ static void kvmppc_get_cpu_characteristics(KVMState *s)
cap_ppc_safe_bounds_check = 1;
}
/* Parse and set cap_ppc_safe_indirect_branch */
- if (c.character & H_CPU_CHAR_BCCTRL_SERIALISED) {
+ if (c.character & c.character_mask & H_CPU_CHAR_BCCTRL_SERIALISED) {
cap_ppc_safe_indirect_branch = 2;
}
}
--
2.14.3
next prev parent reply other threads:[~2018-03-02 6:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 6:03 [Qemu-devel] [PULL 00/24] ppc-for-2.12 queue 20180302 David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 01/24] spapr: fix missing CPU core nodes in DT when running with TCG David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 02/24] ppc440: Add emulation of plb-pcix controller found in some 440 SoCs David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 03/24] ppc: Add aCube Sam460ex board David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 04/24] spapr: register dummy ICPs later David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 05/24] spapr: harden code that depends on VSMT David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 06/24] macio: embed DBDMA device directly within macio David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 07/24] macio: move ESCC device within the macio device David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 08/24] heathrow: QOMify heathrow PIC David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 09/24] heathrow: convert to trace-events David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 10/24] heathrow: change heathrow_pic_init() to return the heathrow device David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 11/24] macio: move macio related structures and defines into separate macio.h file David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 12/24] mac_oldworld: use object link to pass heathrow PIC object to macio David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 13/24] openpic: move KVM-specific declarations into separate openpic_kvm.h file David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 14/24] openpic: move OpenPIC state and related definitions to openpic.h David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 15/24] mac_newworld: use object link to pass OpenPIC object to macio David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 16/24] macio: move setting of CUDA timebase frequency to macio_common_realize() David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 17/24] macio: remove macio_init() function David Gibson
2018-03-02 6:03 ` David Gibson [this message]
2018-03-02 6:03 ` [Qemu-devel] [PULL 19/24] ppc/spapr-caps: Add support for custom spapr_capabilities David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 20/24] ppc/spapr-caps: Convert cap-cfpc to custom spapr-cap David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 21/24] ppc/spapr-caps: Convert cap-sbbc " David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 22/24] ppc/spapr-caps: Convert cap-ibs " David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 23/24] ppc/spapr-caps: Define the pseries-2.12-sxxm machine type David Gibson
2018-03-02 6:03 ` [Qemu-devel] [PULL 24/24] hw/ppc/spapr, e500: Use new property "stdout-path" for boot console David Gibson
2018-03-02 6:26 ` [Qemu-devel] [PULL 00/24] ppc-for-2.12 queue 20180302 no-reply
2018-03-02 14:26 ` Peter Maydell
2018-03-02 17:55 ` [Qemu-devel] [Qemu-ppc] " BALATON Zoltan
2018-03-02 21:51 ` BALATON Zoltan
2018-03-04 23:55 ` [Qemu-devel] " David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302060350.24330-19-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sjitindarsingh@gmail.com \
--cc=surajjs@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).