From: Cornelia Huck <cohuck@redhat.com>
To: "Collin L. Walling" <walling@linux.vnet.ibm.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
borntraeger@de.ibm.com, thuth@redhat.com,
mihajlov@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2] s390/ipl: only print boot menu error if -boot menu=on was specified
Date: Fri, 2 Mar 2018 10:31:41 +0100 [thread overview]
Message-ID: <20180302103141.6b3edb52.cohuck@redhat.com> (raw)
In-Reply-To: <1519760121-24594-1-git-send-email-walling@linux.vnet.ibm.com>
On Tue, 27 Feb 2018 14:35:21 -0500
"Collin L. Walling" <walling@linux.vnet.ibm.com> wrote:
> It is possible that certain QEMU configurations may not
> create an IPLB (such as when -kernel is provided). In
> this case, a misleading error message will be printed
> stating that the "boot menu is not supported for this
> device type".
>
> To amend this, only print this message iff boot menu=on
> was provided on the commandline. Otherwise, return silently.
>
> While we're at it, remove trailing periods from error
> messages.
>
> Signed-off-by: Collin L. Walling <walling@linux.vnet.ibm.com>
> ---
> hw/s390x/ipl.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
Thanks, applied.
prev parent reply other threads:[~2018-03-02 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 19:35 [Qemu-devel] [PATCH v2] s390/ipl: only print boot menu error if -boot menu=on was specified Collin L. Walling
2018-03-01 10:04 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-03-02 8:51 ` [Qemu-devel] " Christian Borntraeger
2018-03-02 9:31 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302103141.6b3edb52.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=mihajlov@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
--cc=walling@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).