From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erh2Z-0002oq-Ra for qemu-devel@nongnu.org; Fri, 02 Mar 2018 04:31:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erh2X-0001j8-9N for qemu-devel@nongnu.org; Fri, 02 Mar 2018 04:31:47 -0500 Date: Fri, 2 Mar 2018 10:31:41 +0100 From: Cornelia Huck Message-ID: <20180302103141.6b3edb52.cohuck@redhat.com> In-Reply-To: <1519760121-24594-1-git-send-email-walling@linux.vnet.ibm.com> References: <1519760121-24594-1-git-send-email-walling@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] s390/ipl: only print boot menu error if -boot menu=on was specified List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Collin L. Walling" Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, borntraeger@de.ibm.com, thuth@redhat.com, mihajlov@linux.vnet.ibm.com On Tue, 27 Feb 2018 14:35:21 -0500 "Collin L. Walling" wrote: > It is possible that certain QEMU configurations may not > create an IPLB (such as when -kernel is provided). In > this case, a misleading error message will be printed > stating that the "boot menu is not supported for this > device type". > > To amend this, only print this message iff boot menu=on > was provided on the commandline. Otherwise, return silently. > > While we're at it, remove trailing periods from error > messages. > > Signed-off-by: Collin L. Walling > --- > hw/s390x/ipl.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) Thanks, applied.