From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Or Idgar <idgar@virtualoco.com>
Cc: ben@skyportsystems.com, dgilbert@redhat.com, mst@redhat.com,
imammedo@redhat.com, eblake@redhat.com, armbru@redhat.com,
qemu-devel@nongnu.org, ghammer@redhat.com,
Or Idgar <oridgar@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v3] vmgenid: allow VM Generation ID modification via QMP/HMP
Date: Fri, 2 Mar 2018 10:57:09 +0000 [thread overview]
Message-ID: <20180302105709.GD26972@redhat.com> (raw)
In-Reply-To: <20180302083720.25137-1-idgar@virtualoco.com>
On Fri, Mar 02, 2018 at 10:37:20AM +0200, Or Idgar wrote:
> From: Or Idgar <oridgar@gmail.com>
>
> This patch allow changing the Virtual Machine Generation
> ID through QMP/HMP while the vm guest is running.
> the spec (http://go.microsoft.com/fwlink/?LinkId=260709)
> mentions that "when the generation ID changes, execute an
> ACPI Notify operation on the generation ID device".
> To test it we need the ability to set the generation ID
> online. QMP/HMP allows that.
If we want to test vmgenid, why don't we simply trigger one of
the mgmt actions that are required to change vmgenid. eg do a
savevm, followed by a loadvm to restore from snapshot. This would
be better testing of the real world usage of this feature.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2018-03-02 10:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 8:37 [Qemu-devel] [PATCH v3] vmgenid: allow VM Generation ID modification via QMP/HMP Or Idgar
2018-03-02 8:49 ` no-reply
2018-03-02 8:52 ` no-reply
2018-03-02 8:53 ` no-reply
2018-03-02 8:55 ` no-reply
2018-03-02 9:29 ` Dr. David Alan Gilbert
2018-03-02 9:37 ` no-reply
2018-03-02 10:22 ` no-reply
2018-03-02 10:57 ` Daniel P. Berrangé [this message]
2018-03-02 17:57 ` Benjamin Warren
2018-03-13 21:22 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302105709.GD26972@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=ben@skyportsystems.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=ghammer@redhat.com \
--cc=idgar@virtualoco.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=oridgar@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).