qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 38/39] target/arm: Decode t32 simd 3reg and 2reg_scalar extension
Date: Fri,  2 Mar 2018 11:06:39 +0000	[thread overview]
Message-ID: <20180302110640.28004-39-peter.maydell@linaro.org> (raw)
In-Reply-To: <20180302110640.28004-1-peter.maydell@linaro.org>

From: Richard Henderson <richard.henderson@linaro.org>

Happily, the bits are in the same places compared to a32.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20180228193125.20577-16-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/translate.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/target/arm/translate.c b/target/arm/translate.c
index 3ad8b4031c..ba6ab7d287 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -10774,7 +10774,19 @@ static void disas_thumb2_insn(DisasContext *s, uint32_t insn)
                                default_exception_el(s));
             break;
         }
-        if (((insn >> 24) & 3) == 3) {
+        if ((insn & 0xfe000a00) == 0xfc000800
+            && arm_dc_feature(s, ARM_FEATURE_V8)) {
+            /* The Thumb2 and ARM encodings are identical.  */
+            if (disas_neon_insn_3same_ext(s, insn)) {
+                goto illegal_op;
+            }
+        } else if ((insn & 0xff000a00) == 0xfe000800
+                   && arm_dc_feature(s, ARM_FEATURE_V8)) {
+            /* The Thumb2 and ARM encodings are identical.  */
+            if (disas_neon_insn_2reg_scalar_ext(s, insn)) {
+                goto illegal_op;
+            }
+        } else if (((insn >> 24) & 3) == 3) {
             /* Translate into the equivalent ARM encoding.  */
             insn = (insn & 0xe2ffffff) | ((insn & (1 << 28)) >> 4) | (1 << 28);
             if (disas_neon_data_insn(s, insn)) {
-- 
2.16.2

  parent reply	other threads:[~2018-03-02 11:07 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-02 11:06 [Qemu-devel] [PULL 00/39] target-arm queue Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 01/39] xlnx-zynqmp-rtc: Initial commit Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 02/39] xlnx-zynqmp-rtc: Add basic time support Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 03/39] xlnx-zynqmp: Connect the RTC device Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 04/39] decodetree: Propagate return value from translate subroutines Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 05/39] loader: Add new load_ramdisk_as() Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 06/39] hw/arm/boot: Honour CPU's address space for image loads Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 07/39] hw/arm/armv7m: " Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 08/39] target/arm: Define an IDAU interface Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 09/39] armv7m: Forward idau property to CPU object Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 10/39] target/arm: Define init-svtor property for the reset secure VTOR value Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 11/39] armv7m: Forward init-svtor property to CPU object Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 12/39] target/arm: Add Cortex-M33 Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 13/39] hw/misc/unimp: Move struct to header file Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 14/39] include/hw/or-irq.h: Add missing include guard Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 15/39] qdev: Add new qdev_init_gpio_in_named_with_opaque() Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 16/39] hw/core/split-irq: Device that splits IRQ lines Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 17/39] hw/misc/mps2-fpgaio: FPGA control block for MPS2 AN505 Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 18/39] hw/misc/tz-ppc: Model TrustZone peripheral protection controller Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 19/39] hw/misc/iotkit-secctl: Arm IoT Kit security controller initial skeleton Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 20/39] hw/misc/iotkit-secctl: Add handling for PPCs Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 21/39] hw/misc/iotkit-secctl: Add remaining simple registers Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 22/39] hw/arm/iotkit: Model Arm IOT Kit Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 23/39] mps2-an505: New board model: MPS2 with AN505 Cortex-M33 FPGA image Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 24/39] target/arm: Add ARM_FEATURE_V8_RDM Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 25/39] target/arm: Refactor disas_simd_indexed decode Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 26/39] target/arm: Refactor disas_simd_indexed size checks Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 27/39] target/arm: Decode aa64 armv8.1 scalar three same extra Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 28/39] target/arm: Decode aa64 armv8.1 " Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 29/39] target/arm: Decode aa64 armv8.1 scalar/vector x indexed element Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 30/39] target/arm: Decode aa32 armv8.1 three same Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 31/39] target/arm: Decode aa32 armv8.1 two reg and a scalar Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 32/39] target/arm: Enable ARM_FEATURE_V8_RDM Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 33/39] target/arm: Add ARM_FEATURE_V8_FCMA Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 34/39] target/arm: Decode aa64 armv8.3 fcadd Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 35/39] target/arm: Decode aa64 armv8.3 fcmla Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 36/39] target/arm: Decode aa32 armv8.3 3-same Peter Maydell
2018-03-02 11:06 ` [Qemu-devel] [PULL 37/39] target/arm: Decode aa32 armv8.3 2-reg-index Peter Maydell
2018-03-02 11:06 ` Peter Maydell [this message]
2018-03-02 11:06 ` [Qemu-devel] [PULL 39/39] target/arm: Enable ARM_FEATURE_V8_FCMA Peter Maydell
2018-03-02 11:42 ` [Qemu-devel] [PULL 00/39] target-arm queue no-reply
2018-03-02 15:45 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180302110640.28004-39-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).