From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erhhC-0006m4-RR for qemu-devel@nongnu.org; Fri, 02 Mar 2018 05:13:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erhh9-0002Pa-Cy for qemu-devel@nongnu.org; Fri, 02 Mar 2018 05:13:46 -0500 Date: Fri, 2 Mar 2018 11:13:39 +0100 From: Cornelia Huck Message-ID: <20180302111339.2f1f2ba6.cohuck@redhat.com> In-Reply-To: <1519944838-12430-13-git-send-email-cota@braap.org> References: <1519944838-12430-1-git-send-email-cota@braap.org> <1519944838-12430-13-git-send-email-cota@braap.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv1 12/14] target/s390x: convert to TranslatorOps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" Cc: qemu-devel@nongnu.org, Richard Henderson , David Hildenbrand , Alexander Graf , qemu-s390x@nongnu.org On Thu, 1 Mar 2018 17:53:56 -0500 "Emilio G. Cota" wrote: > Note: I looked into dropping dc->do_debug. However, I don't see > an easy way to do it given that TOO_MANY is also valid > when we just translate more than max_insns. Thus, the check > for do_debug in "case DISAS_PC_CC_UPDATED" would still need > additional state to know whether or not we came from > breakpoint_check. > > Cc: David Hildenbrand > Cc: Cornelia Huck > Cc: Alexander Graf > Cc: qemu-s390x@nongnu.org > Signed-off-by: Emilio G. Cota > --- > target/s390x/translate.c | 162 +++++++++++++++++++++++------------------------ > 1 file changed, 80 insertions(+), 82 deletions(-) Acked-by: Cornelia Huck